Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx github auth for all the tooling #65

Closed
david-mcmahon opened this issue Sep 7, 2016 · 4 comments
Closed

FIx github auth for all the tooling #65

david-mcmahon opened this issue Sep 7, 2016 · 4 comments
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@david-mcmahon
Copy link
Contributor

The handling of github authentication is much like the rest of the tooling prereqs in this repo. It should be a no-assumed-knowledge, guided process that handholds the user to getting their auth set up correct so they can get on with their lives (the running of the tool).

We make a few attempts to get auth set up correctly.

Additional things we should be doing:

  • Guide users using typical workflows and authentication methods and integrate those workflows into tooling here (using the man pages and/or messages that come with auth errors).
  • Look into the long running TODO to get an auth state earlier in the execution flow.
@david-mcmahon david-mcmahon added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 21, 2016
@mattymo
Copy link
Contributor

mattymo commented Oct 12, 2016

What would you like to see improved? Open a browser automatically to https://github.com/settings/tokens if there is no token set?
If it's set and doesn't work, advise the user to ensure there is a token created the current set of information?

This process can't be automated internally without the user actually logging in.

@david-mcmahon
Copy link
Contributor Author

david-mcmahon commented Oct 12, 2016

anago and other tools run via the command-line. We need to:

  • Understand the different auth mechanisms github uses
  • Figure out which ones are used most commonly
  • Have a check (as early in the script/process as possible) that validates all the necessary auth pathways (mostly push to various branches).
  • The workflow should assume zero knowledge of github auth mechanisms and the user should simply pass the auth check or the auth check should produce a detailed set of steps to achieve the auth required for the operation with instructions on how to continue.

Related (#136), apparently --dry-run behaves differently from non-dry-run. :(

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2017
@david-mcmahon
Copy link
Contributor Author

Release process eventually moving to container builder, the issues raised here are no longer relevant/pressing.

marpaia pushed a commit to marpaia/release that referenced this issue Feb 21, 2019
@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants