Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_acls() not working correctly #142

Closed
saad-ali opened this issue Oct 13, 2016 · 0 comments · Fixed by #143
Closed

check_acls() not working correctly #142

saad-ali opened this issue Oct 13, 2016 · 0 comments · Fixed by #143
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@saad-ali
Copy link
Member

I followed the instruction to set up security layer. The new security layer check passes. But the ACL check fails:

$ ./anago master --nomock
anago: BEGIN main on saadali-dev Wed Oct 12 17:08:05 PDT 2016


────────────────────────────────────────────────────────────────────────────────
CHECK CREDENTIALS
────────────────────────────────────────────────────────────────────────────────

Checking for valid github credentials: OK
Live releases restricted to certain users!


Signal ERR caught!

Traceback (line function script):
171 main ./anago

Exiting...


anago: DONE main on saadali-dev Wed Oct 12 17:08:05 PDT 2016 in 0s

As a sanity check, I modified the anago script to print out the USER and ACL_LIST:

Live releases restricted to certain users! USER is saadali ACL_LIST is
djmm|etune|fabioy|filipg|jessfraz|jgrafton|pwittroc|robertbailey|saadali|stclair

Looks like something is wrong with this script:

check_acls () {
  case "$USER" in
    $ACL_LIST) ;;
            *) logecho "Live releases restricted to certain users!"
               return 1
               ;;
  esac
}
@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants