Fetch remote JSON release notes for official releases #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
@puerco my idea was to change I think for v1.20.0 we can just generate the notes manually and put them as JSON side by side to the markdown draft, too. |
In case we try to download the remote release notes draft as markdown, we also need an equivalent JSON. This patch now assumes that there is a JSON version side by side to the markdown release notes during official, non patch release creation. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Yes! I'll change it today to PR the json along with the draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
In case we try to download the remote release notes draft as markdown,
we also need an equivalent JSON. This patch now assumes that there is a
JSON version side by side to the markdown release notes during official,
non patch release creation.
Which issue(s) this PR fixes:
Refers to #1087
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?