-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes JSON draft #1373
Add release notes JSON draft #1373
Conversation
We will use this JSON draft as artifact during the release process, which allows consumers to get a machine-readable format of the notes. The notes have been generated via: ``` > release-notes --format=json \ --maps-from=$GOPATH/src/k8s.io/sig-release/releases/release-1.20/release-notes/maps \ --start-rev=v1.19.0 \ --end-rev=v1.20.0-rc.0 ``` Signed-off-by: Sascha Grunert <sgrunert@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for assignees
Should be fine when paired #1731, that is unless more edits happen in the coming days (but we should have automated this by then) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oh interesting, I didn't know this workflow. I made edits to the Markdown Draft PR directly on Markdown instead of krel because it was too many to go through sequentially when I already know rhe PR numbers to edit. I'm guessing this command is running through the map instead of the markdown -- correct? if so, that means this JSON might be missing some entries which I added to Markdown manually 😐 |
Are you referring to the mapping workflow itself? Do we lack documentation about it? If it was about the JSON file, then this is new and we definitely have to update the docs. I can follow up on that one.
We always had a gap between the manually edited release notes and the generated JSON in the past, so I guess it’s fine. In the future we can use the maps to synchronize both versions directly. |
JSON file 😄
gotcha! LGTM /hold cancel |
for the record, these are the missing notes which I manually added to #1371 |
What type of PR is this:
/kind feature
What this PR does / why we need it:
We will use this JSON draft as artifact during the release process,
which allows consumers to get a machine-readable format of the notes.
The notes have been generated via:
Which issue(s) this PR fixes:
Refers to kubernetes/release#1087 and kubernetes/release#1815
Special notes for your reviewer:
/cc @wilsonehusin @puerco