-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relnotes in JSON to draft pull request #1821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, but let me be your linter:
cmd/krel/cmd/release_notes.go:334:1: cyclomatic complexity 31 of func `createDraftPR` is high (> 30) (gocyclo)
func createDraftPR(repoPath, tag string) (err error) {
^
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
a0a38d9
to
eb5c806
Compare
I've split the commit creation to its own function to lower the complexity. I'm thinking on doing a major refactor to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
krel release-notes
will now push the JSON version of the release notes draft to k/sig-release when generating the release notes draft pull request.Which issue(s) this PR fixes:
Ref: #1087
Ref: kubernetes/sig-release#1373 (comment)
Special notes for your reviewer:
/hold until 1.20 is cut
Two details with this change:
/cc @saschagrunert @wilsonehusin @cartyc
Does this PR introduce a user-facing change?