Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build go1.18 official images #2464

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Build go1.18 official images #2464

merged 1 commit into from
Mar 19, 2022

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Part of #2307.

its-happening.jpg

Signed-off-by: Stephen Augustus foo@auggie.dev

/assign @puerco @cpanato @xmudrii
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Build go1.18 official images

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2022
@justaugustus
Build go1.18 official images
f94a03d 
`its-happening.jpg`

Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus justaugustus mentioned this pull request Mar 16, 2022
Closed
45 tasks
@justaugustus
Copy link
Member Author

/hold upstream images are not yet available. watch this space: https://doi-janky.infosiftr.net/job/repo-info/job/local/job/golang/

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@cpanato
Copy link
Member

cpanato commented Mar 16, 2022

/retest

@cpanato
Copy link
Member

cpanato commented Mar 16, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Mar 16, 2022
cpanato
cpanato approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2022
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@cpanato
Copy link
Member

cpanato commented Mar 16, 2022

/test pull-release-image-go-runner

xmudrii
xmudrii approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Mar 16, 2022

/retest

@justaugustus
Copy link
Member Author

/test pull-release-image-go-runner

1 similar comment
@cpanato
Copy link
Member

cpanato commented Mar 17, 2022

/test pull-release-image-go-runner

@cpanato
Copy link
Member

cpanato commented Mar 17, 2022

checking

@cpanato
Copy link
Member

cpanato commented Mar 19, 2022

/test pull-release-image-go-runner

@k8s-ci-robot k8s-ci-robot merged commit a515ab3 into kubernetes:master Mar 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 19, 2022
@cpanato
Copy link
Member

cpanato commented Mar 19, 2022

@justaugustus i'm watching the post submits jobs and will do the promotion as soon those are passing/green

@pacoxu pacoxu mentioned this pull request Apr 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @cpanato @k8s-ci-robot @saschagrunert @xmudrii @puerco