Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build using go 1.18.1 #2498

Closed
wants to merge 1 commit into from
Closed

build using go 1.18.1 #2498

wants to merge 1 commit into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Apr 13, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Following #2464
xref kubernetes/kubernetes#108910

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
To complete the pull request process, please assign verolop after the PR has been reviewed.
You can assign the PR to them by writing /assign @verolop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Apr 13, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Apr 13, 2022

/cc @justaugustus saschagrunert

@ameukam
Copy link
Member

ameukam commented Apr 13, 2022

Ref: #2499
cc @kubernetes/release-engineering

@pacoxu pacoxu mentioned this pull request Apr 13, 2022
Closed
saschagrunert
saschagrunert reviewed Apr 13, 2022
View reviewed changes
images/releng/k8s-ci-builder/variants.yaml
@@ -5,11 +5,11 @@ variants:
OS_CODENAME: 'bullseye'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also switch the default config, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.17.8 is using bullseye.
Should we use buster for 1.18.1?

@cpanato
Copy link
Member

cpanato commented Apr 13, 2022

would close this in favor or #2500

@saschagrunert
Copy link
Member

saschagrunert commented Apr 13, 2022 •
edited
Loading

would close this in favor or #2500

Alright, let's go this route. Thank you for this PR @pacoxu! 🙏

@pacoxu
Copy link
Member Author

pacoxu commented Apr 13, 2022

fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert left review comments

@onlydole onlydole Awaiting requested review from onlydole

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees
No one assigned
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pacoxu @k8s-ci-robot @ameukam @cpanato @saschagrunert