Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.9] Code Slush #31

Closed
enisoc opened this issue Nov 17, 2017 · 2 comments
Closed

[1.9] Code Slush #31

enisoc opened this issue Nov 17, 2017 · 2 comments
Assignees
@dashpole
Labels
sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@enisoc
Copy link
Member

enisoc commented Nov 17, 2017

According to the timeline, we should start Code Slush on Mon, Nov 20 (after 3pm PST).

As far as I know, this involves the following:

  • Update submit queue config to set do-not-merge-milestones and additional-required-labels.
    • Block empty milestone, as well as all milestones > v1.9.
    • Require status/approved-for-milestone label.
  • Update milestone bot config to set milestone-modes and milestone-freeze-date.
    • Set mode for v1.9 to slush.
    • Set freeze date to Wed, Nov 22.

@marun Does that look right to you?

cc @jberkus
@marun
Copy link

marun commented Nov 20, 2017

lgtm

@enisoc enisoc mentioned this issue Nov 20, 2017
Merged
@enisoc
Copy link
Member Author

enisoc commented Nov 21, 2017

Code slush is now in effect.

@enisoc enisoc closed this as completed Nov 21, 2017
@justaugustus justaugustus added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashpole dashpole

Labels
sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@marun @justaugustus @dashpole @enisoc