Remove code slush #442
Merged
Remove code slush #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
sig/release
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
lgtm
jdumars
approved these changes
Jan 14, 2019
|
I vastly underestimated how many times the word "slush" is mentioned in playbooks. The following playbooks need an update:
I would rather hold this to take an initial pass |
|
I'm also in favor of this, but definitely would prefer removal across the board so will await the amended commit / PR. |
We decided a clear warning to brace for code freeze was sufficient, and a whole extra delineated phase wasn't worth the effort. We'll still remind folks not to do mean things like land massive changes or refactors N days before code freeze.
spiffxp
force-pushed
the
no-more-code-slush-only-ned-stark
branch
from
ef8b5c4
to
cf0399c
Compare
k8s-ci-robot
added
size/L
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
I traded Slush for Burndown in the context of daily duties being ramped up a week before code freeze
This was the toughest to change, I feel like it needs more of a rewrite from the Bug Triage folks. Tons of text, and more phases than the actual release cycle. It also talked about Burndown solely during the last week, which isn't quite true. In the context of duties changing as phases change, I changed "Slush" to "Burndown", and also changed "Release Burndown" to "Code Thaw"
spiffxp
force-pushed
the
no-more-code-slush-only-ned-stark
branch
from
cf0399c
to
3a97133
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jdumars, justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided a clear warning to brace for code freeze was sufficient,
and a whole extra delineated phase wasn't worth the effort. We'll
still remind folks not to do mean things like land massive changes
or refactors N days before code freeze.
ref: #269