Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PidLimits promoted to GA #18

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

SergeyKanzhelev
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2020
@neolit123
Copy link
Member

Thanks! Lets hold this until the feature PR merges.

This also means we have to release a new Minor of this library and revendor it in k/k.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2020
@neolit123
Copy link
Member

/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2020
@k8s-ci-robot
Copy link
Contributor

@neolit123: The label(s) priority/ cannot be applied, because the repository doesn't have them

In response to this:

/kind feature
/priority important-longterm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Aug 27, 2020
@SergeyKanzhelev
Copy link
Member Author

PR in k/k got merged. I wonder if I can cancel hold on self-authored PR...

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4c2c4b9 into kubernetes:master Sep 9, 2020
@neolit123
Copy link
Member

@SergeyKanzhelev do you happen to know if there are other planned features from SIG node related to this repository?

@SergeyKanzhelev SergeyKanzhelev deleted the pidLimitsGA branch September 9, 2020 19:27
@SergeyKanzhelev
Copy link
Member Author

@SergeyKanzhelev do you happen to know if there are other planned features from SIG node related to this repository?

I don't think so after briefly looking thru the code. even for this change, cutting release is not critical as it is not a breaking change. So perhaps, this can wait in case something else will come up

@neolit123
Copy link
Member

neolit123 commented Sep 9, 2020

ok, since this library's "release process" is a bit bottlenecked on my availability, i'd prefer if we cut the release now and re-vendor in k/k right away to unblock tests if needed(?).

and we can cut more releases here if needed for 1.20 later.

@neolit123
Copy link
Member

here is the new release:
https://github.com/kubernetes/system-validators/releases/tag/v1.2.0

would you be able to send the PR to re-vendor?

here is an example commit on how we update the vendor:
kubernetes/kubernetes@8183787

it uses the script:
https://github.com/kubernetes/kubernetes/blob/master/hack/pin-dependency.sh

@SergeyKanzhelev
Copy link
Member Author

here is the new release:
https://github.com/kubernetes/system-validators/releases/tag/v1.2.0

would you be able to send the PR to re-vendor?

Yes, thank you for the detailed instructions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants