Request approval for specific concepts

[michelle192837]

It might be nice to, in some cases, have approval for specific concepts like languages ("is my X code readable") or docs ("approve .md files but not code"). Prow's approval plugin could be extended to do this, via something like:

• Have a top-level directory with OWNERS files for concepts
  • (e.g. k/t-i/languages/[go|py|ts]/OWNERS)
• When PRs are sent for approval, or on request (via a slash command?), detect the file extensions touched
• Add a fake file that the approval plugin recognizes as touching the relevant approval directory
  • (e.g. approval plugin thinks that k/t-i/languages/go/fakefile was added)
• Approval assigns/requires an approver from the relevant file

/area prow
/priority/backlog

[BenTheElder]

/priority/backlog

/priority backlog

[stevekuznetsov]

We've seen a large number of teams whose workflows don't nicely fit into the LGTM+approve workflow hit this issue, all with specific subsets of the solution they need ... either they want N approvers, or approvers by "type", or both. It might make sense to fix this in a first-class manner (instead of hacking through files) as part of whatever the issue is that we have to track approvers making bad assumptions (I can't for the life of me find it).

[stevekuznetsov]

We've seen a large number of teams whose workflows don't nicely fit into the LGTM+approve workflow hit this issue, all with specific subsets of the solution they need ... either they want N approvers, or approvers by "type", or both. It might make sense to fix this in a first-class manner (instead of hacking through files) as part of whatever the issue is that we have to track approvers making bad assumptions (I can't for the life of me find it).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[nikhita]

/remove-lifecycle stale
xref #7690

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[spiffxp]

/remove-lifecycle rotten
Just got pinged for another variant of this, product readiness approval ref: kubernetes/enhancements#1620 (comment)

[spiffxp]

Another example: ensure someone from sig-instrumentation gets assigned to PRs that change metrics-related code kubernetes/kubernetes#89788

[spiffxp]

We can't currently use solutions that regex against paths or file types because the approvers plugin doesn't cooperate with filters (ref: #7690)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.