Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops - Fix image used by some presubmit jobs #15691

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Dec 26, 2019

The old image has not been updated in almost a year and is still running Go 1.11:

docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3 version
go version go1.11.5 linux/amd64

We have open PRs which are not compatible with go 1.11 which is causing their presubmits to fail.
This switches those jobs to use the same kubekins image as the E2E jobs.
I see other projects using the same kubekins-e2e image for non-e2e jobs as well.

The new image has Go 1.13 as we expect:

docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental version
go version go1.13.4 linux/amd64

The old image has not been updated in almost a year [0] and is still running Go 1.11:

```
docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3 version
go version go1.11.5 linux/amd64
```

We have open PRs [1] which are not compatible with go 1.11 which is causing their presubmits to fail.
This switches those jobs to use the same kubekins image as the E2E jobs.
I see other projects using the same kubekins-e2e image for non-e2e jobs as well [2].

The new image has Go 1.13 as we expect:

```
docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental version
go version go1.13.4 linux/amd64
```

[0] https://console.cloud.google.com/gcr/images/k8s-testimages/GLOBAL/gcloud-in-go?gcrImageListsize=30
[1] kubernetes/kops#8203
[2] https://github.com/kubernetes/test-infra/blob/c628c3674eb0c9292812d760232afcdbb7c79c99/config/jobs/kubernetes-sigs/cluster-api-provider-aws/cluster-api-provider-aws-presubmits.yaml#L23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 26, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 26, 2019
@johngmyers
Copy link
Member

johngmyers commented Dec 26, 2019

So "best effort" on Go 1.12 means we only CI on it in Travis? Or should we remove 1.12 from Travis?

Perhaps Go 1.12 should be an agenda item for kops office hours.

@rifelpet
Copy link
Member Author

Our go.mod file and released builds (from Justin's workstation) use 1.13. I think "best effort" implies that we'll continue to test against 1.12 but if we end up needing to do something incompatible with 1.12, it will be a conscious decision and at that point we'll consider dropping our 1.12 Travis CI tests.

@justinsb
Copy link
Member

Let's try it!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fb2489d into kubernetes:master Dec 27, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 27, 2019
@k8s-ci-robot
Copy link
Contributor

@rifelpet: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kops-config.yaml using file config/jobs/kubernetes/kops/kops-config.yaml

In response to this:

The old image has not been updated in almost a year and is still running Go 1.11:

docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/gcloud-in-go:v20190125-cc5d6ecff3 version
go version go1.11.5 linux/amd64

We have open PRs which are not compatible with go 1.11 which is causing their presubmits to fail.
This switches those jobs to use the same kubekins image as the E2E jobs.
I see other projects using the same kubekins-e2e image for non-e2e jobs as well.

The new image has Go 1.13 as we expect:

docker run --entrypoint=/usr/local/go/bin/go gcr.io/k8s-testimages/kubekins-e2e:v20191219-72db7a6-experimental version
go version go1.13.4 linux/amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants