Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops - Use the release/stable marker until the next beta #17805

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 2, 2020

For kubernetes/kops#9204 to work, a new 1.19 beta is needed.
Until then we should continue to use the release/stable marker.

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 2, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 2, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8b79184 into kubernetes:master Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

@hakman: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kops-presubmits.yaml using file config/jobs/kubernetes/kops/kops-presubmits.yaml

In response to this:

For kubernetes/kops#9204 to work, a new 1.19 beta is needed.
Until then we should continue to use the release/stable marker.

/cc @rifelpet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants