Update kube dependencies to 1.18.6 #17869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/kubetest
area/prow
|
Blocked by knative/pkg#1387 , knatives api imports a client, that's some very impressive shit. |
k8s-ci-robot
added
the
needs-rebase
fejta
reviewed
Jul 14, 2020
go.mod
Outdated
| k8s.io/apimachinery => k8s.io/apimachinery v0.17.3 | ||
| k8s.io/client-go => k8s.io/client-go v0.17.3 | ||
| k8s.io/code-generator => k8s.io/code-generator v0.17.3 | ||
| k8s.io/api => k8s.io/api v0.18.3 |
There was a problem hiding this comment.
Looks like we can get rid of these replace stanzas?
alvaroaleman
force-pushed
the
update-kube
branch
from
2920b74
to
9290bba
Compare
k8s-ci-robot
added
size/XXL
alvaroaleman
changed the title
alvaroaleman
force-pushed
the
update-kube
branch
2 times, most recently
from
8d90ce4
to
a750f27
Compare
|
/assign @amwat |
Merged
|
it's been removed, in #18567 |
k8s-ci-robot
added
the
needs-rebase
alvaroaleman
force-pushed
the
update-kube
branch
from
6326b98
to
6ae19b4
Compare
k8s-ci-robot
removed
the
needs-rebase
alvaroaleman
force-pushed
the
update-kube
branch
5 times, most recently
from
01abcad
to
fbaa80d
Compare
alvaroaleman
force-pushed
the
update-kube
branch
from
fbaa80d
to
dfceaa5
Compare
|
/retest |
alvaroaleman
commented
Jul 31, 2020
| github.com/Azure/go-autorest => github.com/Azure/go-autorest v12.2.0+incompatible | ||
| github.com/docker/docker => github.com/docker/docker v1.4.2-0.20200203170920-46ec8731fbce |
There was a problem hiding this comment.
Not sure why, but without the replacements, ./hack/update-deps.sh would update the pubsub and docker dependencies, causing compilation failures.
I've pinned all the k8s dependencies to make sure we use the same version for everything
|
/assign fejta |
fejta
approved these changes
Jul 31, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, fejta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes some changes to the generated clients, all their methods now take a
context.Contextas first and ametav1.<<METHOD>>Optionsas last argument. Those were fixed via https://github.com/kubernetes-sigs/clientgofix or manually when we re-defined a sub interface.