Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable parallel test runs to prevent test skips #20593

Merged
merged 1 commit into from
Jan 25, 2021
Merged

disable parallel test runs to prevent test skips #20593

merged 1 commit into from
Jan 25, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jan 25, 2021

Running in parallel causes some of the tests to be skipped because of unavailable nodes. So setting --ginkgo-parallel=1 to ensure all the dual-stack tests are run.

�[36m�[1mS [SKIPPING] [25.828 seconds]�[0m
[sig-network] [Feature:IPv6DualStackAlphaFeature] [LinuxOnly]
�[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/framework.go:23�[0m
  Granular Checks: Services Secondary IP Family
  �[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/dual_stack.go:443�[0m
    �[36m�[1mshould function for node-Service: udp [It]�[0m
    �[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/dual_stack.go:482�[0m

    �[36mRequires at least 2 nodes (not -1)�[0m

    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/network/utils.go:753

We can optimize the # in a follow up PR to reduce the time taken to run the tests.

/assign @aojea
cc @lachie83 @bridgetkromhout

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 25, 2021
aojea
aojea reviewed Jan 25, 2021
View reviewed changes
config/jobs/kubernetes/sig-network/dualstack-e2e.yaml
@@ -196,7 +196,7 @@ periodics:
# Skipping "Should recreate evicted statefulset" because of an issue in dockershim for dualstack
# Suggested fix - https://github.com/kubernetes/kubernetes/pull/94382
- --test_args=--ginkgo.focus=\[Feature:IPv6DualStackAlphaFeature\]|\[Conformance\] --ginkgo.skip=\[Slow\]|\[Serial\]|\[Flaky\]|Should.recreate.evicted.statefulset
- --ginkgo-parallel=20
- --ginkgo-parallel=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC you just need to remove the ginkgo-parallel line entirely.

In that case you can run the serial tests too, that are being skipped now, FYI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm following the same format for all the jobs defined in the yaml: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-network/dualstack-e2e.yaml#L152.

We can enable Serial tests in a follow up PR after few test runs. I'm planning to do it incrementally 😄

btw, 1.20 branch tests are running all the dual-stack tests as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@aojea
Copy link
Member

aojea commented Jan 25, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2021
@k8s-ci-robot k8s-ci-robot merged commit c63cef9 into kubernetes:master Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 25, 2021
@k8s-ci-robot
Copy link
Contributor

@aramase: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key dualstack-e2e.yaml using file config/jobs/kubernetes/sig-network/dualstack-e2e.yaml

In response to this:

Running in parallel causes some of the tests to be skipped because of unavailable nodes. So setting --ginkgo-parallel=1 to ensure all the dual-stack tests are run.

�[36m�[1mS [SKIPPING] [25.828 seconds]�[0m
[sig-network] [Feature:IPv6DualStackAlphaFeature] [LinuxOnly]
�[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/framework.go:23�[0m
 Granular Checks: Services Secondary IP Family
 �[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/dual_stack.go:443�[0m
   �[36m�[1mshould function for node-Service: udp [It]�[0m
   �[90m/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/network/dual_stack.go:482�[0m

   �[36mRequires at least 2 nodes (not -1)�[0m

   /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/network/utils.go:753

We can optimize the # in a follow up PR to reduce the time taken to run the tests.

/assign @aojea
cc @lachie83 @bridgetkromhout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aramase aramase deleted the disable-parallel branch January 25, 2021 22:17
This was referenced Jan 25, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@bowei bowei Awaiting requested review from bowei

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@aramase @aojea @k8s-ci-robot