Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs: skip test-e2e on release-0.10 #30479

Merged
merged 1 commit into from
Aug 23, 2023
Merged

config/jobs: skip test-e2e on release-0.10 #30479

merged 1 commit into from
Aug 23, 2023

Conversation

dgrisonnet
Copy link
Member

The test-e2e job of prometheus-adapter was introduced after release 0.10, so the target for this test doesn't exist on branch release-0.10.

@dgrisonnet
config/jobs: skip test-e2e on release-0.10
cbb81a9 
The test-e2e job of prometheus-adapter was introduced after release
0.10, so the target for this test doesn't exist on branch release-0.10.

Signed-off-by: Damien Grisonnet <dgrisonn@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@rexagod
Copy link
Member

rexagod commented Aug 23, 2023

Makes sense.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 35c3413 into kubernetes:master Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

@dgrisonnet: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key prometheus-adapter-presubmits.yaml using file config/jobs/kubernetes-sigs/prometheus-adapter/prometheus-adapter-presubmits.yaml

In response to this:

The test-e2e job of prometheus-adapter was introduced after release 0.10, so the target for this test doesn't exist on branch release-0.10.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dgrisonnet dgrisonnet mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@rexagod rexagod

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgrisonnet @k8s-ci-robot @rexagod