Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kOps: migrate a few tests to kops-prow-build #31612

Merged
merged 2 commits into from
Jan 16, 2024
Merged

kOps: migrate a few tests to kops-prow-build #31612

merged 2 commits into from
Jan 16, 2024

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jan 12, 2024

Part of:

Tentative to move aws-related jobs to a new build cluster.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2024
ameukam
ameukam commented Jan 12, 2024
View reviewed changes
config/jobs/kubernetes/kops/build_jobs.py Outdated
Comment on lines 20 to 24
import jinja2 # pylint: disable=import-error
import yaml
from helpers import ( # pylint: disable=import-error, no-name-in-module
build_cron, create_args, distro_images, distros_ssh_user, k8s_version_info,
should_skip_newer_k8s)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small reorg of the python modules.

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 12, 2024
@ameukam
Copy link
Member Author

ameukam commented Jan 12, 2024

cc @hakman @rifelpet @justinsb

Not sure about the right approach here.

ameukam
ameukam commented Jan 12, 2024
View reviewed changes
config/jobs/kubernetes/kops/templates/periodic-scenario.yaml.jinja
Comment on lines -8 to -10
{%- if not boskos_resource_type %}
preset-aws-credential: "true"
{%- endif %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is impact the scale tests because the credentials are needed in another cluster.

@hakman
Copy link
Member

hakman commented Jan 14, 2024

Let's give this a try
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 14, 2024
@ameukam ameukam marked this pull request as ready for review January 15, 2024 21:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2024
@ameukam
Copy link
Member Author

ameukam commented Jan 15, 2024

/retest

@ameukam
kOps: migrate a few tests to kops-prow-build
622400b 
Part of:
 - kubernetes/k8s.io#5127

Tentative to move aws-related jobs to a new build cluster.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Exclude scale test from jobs build script.
ab72563 
Exclude the scale test from the tests maintained by build_jobs.py.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam ameukam force-pushed the kops-migrate-periodic-scenarios branch from 77a2ed3 to ab72563 Compare January 15, 2024 22:03
@ameukam
Copy link
Member Author

ameukam commented Jan 15, 2024

@hakman Need another LGTM. PTAL. 🙏🏾

@hakman
Copy link
Member

hakman commented Jan 16, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot merged commit a3d4b4e into kubernetes:master Jan 16, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ameukam: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kops-periodics-misc2.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc2.yaml
  • key kops-periodics-upgrades.yaml using file config/jobs/kubernetes/kops/kops-periodics-upgrades.yaml

In response to this:

Part of:

Tentative to move aws-related jobs to a new build cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Feb 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@zetaab zetaab Awaiting requested review from zetaab

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @hakman