-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes_e2e.py: remove working dir check if --build
is specified
#32519
Conversation
The job `pull-release-cluster-up` is failing right now with: ``` + /workspace/scenarios/kubernetes_e2e.py --build=quick --cluster= --down=false --extract=local --gcp-node-image=gci --gcp-nodes=4 --gcp-zone=us-west1-b --provider=gce --test_args=--ginkgo.focus=definitely-not-a-real-focus --timeout=65m Traceback (most recent call last): File "/workspace/scenarios/kubernetes_e2e.py", line 391, in <module> main(parse_args()) File "/workspace/scenarios/kubernetes_e2e.py", line 259, in main raise ValueError(k8s) ValueError: /home/prow/go/src/github.com/kubernetes/release ``` Reason for that is that the current working director is already `/home/prow/go/src/github.com/kubernetes/release`, while the script expects to be in `kubernetes/kubernetes`. It does not seem to matter much for `kubetest` in which working directory we are, means we can remove the check completely. Also the method `add_k8s` does not do anything at all which means we can remove it, too. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @BenTheElder did't we freeze this script? |
/hold Please stop using scenario scripts. These are a holdover from bootstrap.py. All jobs should be using prow |
These have been deprecated since 2018 and we've eliminated most of the users https://github.com/kubernetes/test-infra/tree/master/scenarios |
@BenTheElder I see. We have to move away from |
The job
pull-release-cluster-up
is failing right now with:Reason for that is that the current working directory is already
/home/prow/go/src/github.com/kubernetes/release
while the script expects to be inkubernetes/kubernetes
. It does not seem to matter much forkubetest
in which working directory we are, means we can remove the check completely. Also the methodadd_k8s
does not do anything at all which means we can remove it, too.cc @kubernetes/release-engineering
Should fix kubernetes/release#3588