sig-testing: uses LABEL_FILTER instead of FOCUS #32867
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| presubmits: | ||
| kubernetes/kubernetes: | ||
| # Please update the pull-kubernetes-e2e-kind-canary job first when making potentially intrusive changes. | ||
| # After the canary job is green and merged, update this job. | ||
| - name: pull-kubernetes-e2e-kind | ||
| cluster: k8s-infra-prow-build | ||
| optional: false | ||
|
|
@@ -23,11 +25,11 @@ presubmits: | |
| - -c | ||
| - curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" && e2e-k8s.sh | ||
| env: | ||
| - name: LABEL_FILTER | ||
| value: "Feature: isEmpty" | ||
| # TODO(bentheelder): reduce the skip list further | ||
| - name: SKIP | ||
| value: \[Slow\]|\[Disruptive\]|\[Flaky\]||PodSecurityPolicy|LoadBalancer|load.balancer|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing|NFS|nfs|inline.execution.and.attach|should.be.rejected.when.no.endpoints.exist | ||
| - name: PARALLEL | ||
| value: "true" | ||
| # we need privileged mode in order to do docker in docker | ||
|
|
@@ -46,7 +48,10 @@ presubmits: | |
| testgrid-create-test-group: 'true' | ||
| fork-per-release: "true" | ||
|
|
||
| # The "canary" job for iterating on changes before promoting them to the pull-kubernetes-e2e-kind job. | ||
| # It should keep the same configuration as the pull-kubernetes-e2e-kind job except for the SKIP list. | ||
| # We can keep the canary running more tests, it is optional and can be used to get signal on PRs. | ||
| # The problem is the other way around, if the normal job runs more tests than the canary. | ||
| - name: pull-kubernetes-e2e-kind-canary | ||
| cluster: k8s-infra-prow-build | ||
| optional: true | ||
|
|
@@ -93,6 +98,8 @@ presubmits: | |
| testgrid-alert-stale-results-hours: '24' | ||
| testgrid-create-test-group: 'true' | ||
|
|
||
| # Please update the pull-kubernetes-e2e-kind-ipv6-canary job first when making potentially intrusive changes. | ||
| # After the canary job is green and merged, update this job. | ||
| - name: pull-kubernetes-e2e-kind-ipv6 | ||
| cluster: k8s-infra-prow-build | ||
| optional: false | ||
|
|
@@ -117,11 +124,11 @@ presubmits: | |
| - -c | ||
| - curl -sSL https://kind.sigs.k8s.io/dl/latest/linux-amd64.tgz | tar xvfz - -C "${PATH%%:*}/" && e2e-k8s.sh | ||
| env: | ||
| - name: LABEL_FILTER | ||
| value: "Feature: isEmpty" | ||
| # TODO(bentheelder): reduce the skip list further | ||
| - name: SKIP | ||
| value: \[Slow\]|\[Disruptive\]|\[Flaky\]|\[sig-storage\]|PodSecurityPolicy|LoadBalancer|load.balancer|In-tree.Volumes.\[Driver:.nfs\]|PersistentVolumes.NFS|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing | ||
| - name: PARALLEL | ||
| value: "true" | ||
| # enable IPV6 in bootstrap image | ||
|
|
@@ -146,6 +153,10 @@ presubmits: | |
| testgrid-alert-stale-results-hours: '24' | ||
| testgrid-create-test-group: 'true' | ||
|
|
||
| # The "canary" job for iterating on changes before promoting them to the pull-kubernetes-e2e-kind-ipv6 job. | ||
| # It should keep the same configuration as the pull-kubernetes-e2e-kind-ipv6 job except for the SKIP list. | ||
| # We can keep the canary running more tests, it is optional and can be used to get signal on PRs. | ||
| # The problem is the other way around, if the normal job runs more tests than the canary. | ||
| - name: pull-kubernetes-e2e-kind-ipv6-canary | ||
| cluster: k8s-infra-prow-build | ||
| optional: true | ||
|
|
@@ -454,10 +465,10 @@ presubmits: | |
| value: '{"EventedPLEG":true}' | ||
| - name: RUNTIME_CONFIG | ||
| value: '{"api/alpha":"true", "api/ga":"true"}' | ||
|
There was a problem hiding this comment. @pacoxu should the job pull-kubernetes-e2e-kind-evented-pleg be moved into |
||
| - name: LABEL_FILTER | ||
| value: "Feature: isEmpty" | ||
| - name: SKIP | ||
| value: \[Slow\]|\[Disruptive\]|\[Flaky\]|PodSecurityPolicy|LoadBalancer|load.balancer|In-tree.Volumes.\[Driver:.nfs\]|PersistentVolumes.NFS|Network.should.set.TCP.CLOSE_WAIT.timeout|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing|should.provide.basic.identity | ||
| - name: PARALLEL | ||
| value: "true" | ||
| # we need privileged mode in order to do docker in docker | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we ever test this with a canary job first? we appear to be running ZERO test cases now kubernetes/kubernetes#126401
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we did. Let's discuss on Slack.