Have pull-kops-e2e-kubernetes-aws extract ci/latest #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We bring up the cluster with ci/latest, so we should run those tests also.
k8s-ci-robot
added
cncf-cla: yes
|
The kops PR builder is currently failing because it is running the 1.7 e2e tests against a 1.9-alpha cluster, a and 1.8 added validation which the 1.7 e2e tests violate (kubernetes/kubernetes#47224) This can be seen in the logs for kubernetes/kops#3336 here: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kops/3336/pull-kops-e2e-kubernetes-aws/2906/build-log.txt We run kubetest and create the cluster with 1.9: But then we get our e2e tests from release/stable, from extract: I believe this can be fixed by setting |
|
ah makes sense. |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Sep 24, 2017
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Allow dns e2e test case for ExternalName to run on aws **What this PR does / why we need it**: #52840 uses allocated clusterIP instead of hard-coded one. So we don't need to care about the clusterIP range of the CI job config. Let it run on pull-kubernetes-e2e-kops-aws **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47224 **Special notes for your reviewer**: ref: kubernetes/test-infra#4462 /cc @bowei @MrHohn @justinsb **Release note**: ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We bring up the cluster with ci/latest, so we should run those tests
also.