-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run dep ensure -update
#5988
Run dep ensure -update
#5988
Conversation
a39c4f1
to
52a5c56
Compare
/ok-to-test |
52a5c56
to
7e5c8fa
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oomichi Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
4e217f1
to
960ec86
Compare
`dep ensure` never came back over 20mins on test-infra repo. This fixes the issue by operating `dep ensure -update` and `hack/update-bazel.sh`.
960ec86
to
fa0f7a8
Compare
`go vet` fails due to github library changes:: k8s.io/test-infra/ghclient ghclient/core.go:60:14: cannot use client.Repositories (type *github.RepositoriesService) as type repositoryService in field value: *github.RepositoriesService does not implement repositoryService (wrong type for ListCollaborators method) have ListCollaborators(context.Context, string, string, *github.ListCollaboratorsOptions) ([]*github.User *github.Response, error) want ListCollaborators(context.Context, string, string, *github.ListOptions) ([]*github.User, *github.Response error) This patch makes ghclient follow these changes.
fa0f7a8
to
ff51904
Compare
/assign @cblecker |
This doesn't build currently due to mungegithub, do we really need the churn to update everything? We should be moving mungegithub out to a graveyard or something in the near future but until then we probably don't want to do much with it. |
This makes mungegithub follow github changes to avoid errors:: mungegithub/github/github.go:723:29: cannot use prot.RequiredPullRequestReviews (type *github.PullRequestReviewsEnforcement) as type *github.PullRequestReviewsEnforcementRequest in field value mungegithub/github/github.go:1360:10: cannot use listOpts (type *github.ListOptions) as type *github.ListCollaboratorsOptions in argument to config.client.Repositories.ListCollaborators
c6efdd1
to
b5c7ba2
Compare
@oomichi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thank you for your comment, I count not follow "graveyard" in the above comment, does it mean we can remove mungegithub from test-infra repo with moving the code to another repo? I cannot find "graveyard" repo, anyways. |
I feel I see the point. Mungegithub itself is deprecated as the README.rst and we are migrating all mungers from mungegithub to prow1. TBH, I don't care of updating these code, I just want to import go-openapi as a new vendor code with |
@oomichi have you tried a I'd suggest we close this PR out, and we can help diagnose your local env in #5987. |
@cblecker Yeah, it is nice to drop this PR and discuss the issue on the issue. |
dep ensure
never came back over 20mins on test-infra repo.This fixes the issue by operating
dep ensure -update
andhack/update-bazel.sh
.fixes #5987