Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup merge automation for kubernetes-client repos #9122

Merged
merged 3 commits into from
Aug 22, 2018

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 22, 2018

This will turn on /lgtm, /approve, and auto-merging via tide. Same automation
that's used by all repos in kubernetes-sigs and kubernetes-csi.

/sig contributor-experience
/area github-management
/kind cleanup
/sig api-machinery

/cc @brendandburns @mbohlool
You have admin/write access to most of the kubernetes-client repos

/cc @roycaihw @yliaog @dims @lavalamp
You have admin/write access to the rest (as collaborators). Since you're already kubernetes
members I'd encourage you to file a membership request for kubernetes-client
and mention that. The requirements/sponsors and PR/issue lists can be skipped in that case

/hold
for comment

This is the main audience impacted, so I'm not inclined to send a k-dev@ lazy conensus e-mail.
I'm most interested in hearing from @brendandburns and @yliaog as the most active mergers recently.

Based on prior commits it looks like csharp and gen use the
squash method of merging, everything else left at default
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2018
@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow labels Aug 22, 2018
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not using bot command so others can review)

@@ -332,6 +342,8 @@ tide:
kubernetes/website: squash
kubernetes/kubernetes-docs-ja: squash
kubernetes/kubernetes-docs-ko: squash
kubernetes-client/csharp: squash
kubernetes-client/gen: squash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the reason for not listing other repos under kubernetes-client here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my exploration of other repos' commit history, these are the only two repos that use the squash method, the rest use the default. If the desire is to move everything to squash, that is doable via PR. I'm also fine having these two repos use the same merge method as everything else.

My goal with this PR is to automate the state of today, and then back away and let you change as you see fit.

Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yliaog
Copy link
Contributor

yliaog commented Aug 22, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@brendandburns
Copy link
Contributor

LGTM, this is great, thanks!

@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, spiffxp, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brendandburns
Copy link
Contributor

/unhold

@spiffxp
Copy link
Member Author

spiffxp commented Aug 22, 2018

/hold cancel
deploying

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5a8f64b into kubernetes:master Aug 22, 2018
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Updated the following 2 configmaps:

  • config configmap using the following files:
    • key config.yaml using file prow/config.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file prow/plugins.yaml

In response to this:

This will turn on /lgtm, /approve, and auto-merging via tide. Same automation
that's used by all repos in kubernetes-sigs and kubernetes-csi.

/sig contributor-experience
/area github-management
/kind cleanup
/sig api-machinery

/cc @brendandburns @mbohlool
You have admin/write access to most of the kubernetes-client repos

/cc @roycaihw @yliaog @dims @lavalamp
You have admin/write access to the rest (as collaborators). Since you're already kubernetes
members I'd encourage you to file a membership request for kubernetes-client
and mention that. The requirements/sponsors and PR/issue lists can be skipped in that case

/hold
for comment

This is the main audience impacted, so I'm not inclined to send a k-dev@ lazy conensus e-mail.
I'm most interested in hearing from @brendandburns and @yliaog as the most active mergers recently.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants