-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup merge automation for kubernetes-client repos #9122
Setup merge automation for kubernetes-client repos #9122
Conversation
Based on prior commits it looks like csharp and gen use the squash method of merging, everything else left at default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not using bot command so others can review)
@@ -332,6 +342,8 @@ tide: | |||
kubernetes/website: squash | |||
kubernetes/kubernetes-docs-ja: squash | |||
kubernetes/kubernetes-docs-ko: squash | |||
kubernetes-client/csharp: squash | |||
kubernetes-client/gen: squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the reason for not listing other repos under kubernetes-client here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my exploration of other repos' commit history, these are the only two repos that use the squash method, the rest use the default. If the desire is to move everything to squash, that is doable via PR. I'm also fine having these two repos use the same merge method as everything else.
My goal with this PR is to automate the state of today, and then back away and let you change as you see fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
LGTM, this is great, thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, spiffxp, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/hold cancel |
@spiffxp: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will turn on /lgtm, /approve, and auto-merging via tide. Same automation
that's used by all repos in kubernetes-sigs and kubernetes-csi.
/sig contributor-experience
/area github-management
/kind cleanup
/sig api-machinery
/cc @brendandburns @mbohlool
You have admin/write access to most of the kubernetes-client repos
/cc @roycaihw @yliaog @dims @lavalamp
You have admin/write access to the rest (as collaborators). Since you're already kubernetes
members I'd encourage you to file a membership request for kubernetes-client
and mention that. The requirements/sponsors and PR/issue lists can be skipped in that case
/hold
for comment
This is the main audience impacted, so I'm not inclined to send a k-dev@ lazy conensus e-mail.
I'm most interested in hearing from @brendandburns and @yliaog as the most active mergers recently.