Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding prow configuration for aws-alb-ingress-controller #9976

Merged
merged 1 commit into from
Nov 2, 2018
Merged

adding prow configuration for aws-alb-ingress-controller #9976

merged 1 commit into from
Nov 2, 2018

Conversation

M00nF1sh
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2018
Copy link
Contributor Author

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @krzyzacy can we mount our coveralls / dockerhub token as secret into prow cluster, so we can fully deprecate travis?

@gyuho gyuho mentioned this pull request Oct 31, 2018
12 tasks
@M00nF1sh
Copy link
Contributor Author

M00nF1sh commented Nov 1, 2018

@krzyzacy Hi, would help take a look at this 😸 , thanks a lot 😄

@M00nF1sh
Copy link
Contributor Author

M00nF1sh commented Nov 1, 2018

/assign @krzyzacy

- runner.sh
args:
- make
- test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: new line

@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2018

/ok-to-test

@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2018

can we mount our coveralls / dockerhub token as secret into prow cluster, so we can fully deprecate travis?

what's the token for?

@M00nF1sh
Copy link
Contributor Author

M00nF1sh commented Nov 1, 2018

can we mount our coveralls / dockerhub token as secret into prow cluster, so we can fully deprecate travis?

what's the token for?

It will be used for report code coverage during unit test into coveralls.io 😄
I can see gce-multiple-ingress did similar thing: https://github.com/kubernetes/test-infra/blob/master/config/jobs/GoogleCloudPlatform/k8s-multicluster-ingress/k8s-multicluster-ingress-config.yaml#L94

@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2018

The token will be seen for other jobs running on the same cluster. If that's fine to you then I'm happy to add that for you. Or else you can give us a build cluster instead.

@M00nF1sh
Copy link
Contributor Author

M00nF1sh commented Nov 1, 2018

thanks so much for helping 😸 . The coveralls token is not security related, and it'll be fine to be viewed by all k8s jobs 😄 . Can i send you the token on slack or email?

@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2018

sure

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow area/testgrid labels Nov 1, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Nov 1, 2018

(add a secret named k8s-aws-alb-ingress-coveralls-token)

Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01189f28f9f5bc8f468bca79034e4e7b6e603f17

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzyzacy, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 753f266 into kubernetes:master Nov 2, 2018
@k8s-ci-robot
Copy link
Contributor

@M00nF1sh: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key aws-alb-ingress-controller-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-alb-ingress-controller/aws-alb-ingress-controller-presubmits.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file prow/plugins.yaml

In response to this:

Ref: kubernetes-sigs/aws-load-balancer-controller#706
Ref: #9814

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants