-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding prow configuration for aws-alb-ingress-controller #9976
Conversation
...g/jobs/kubernetes-sigs/aws-alb-ingress-controller/aws-alb-ingress-controller-presubmits.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @krzyzacy can we mount our coveralls / dockerhub token as secret into prow cluster, so we can fully deprecate travis?
...g/jobs/kubernetes-sigs/aws-alb-ingress-controller/aws-alb-ingress-controller-presubmits.yaml
Show resolved
Hide resolved
@krzyzacy Hi, would help take a look at this 😸 , thanks a lot 😄 |
/assign @krzyzacy |
- runner.sh | ||
args: | ||
- make | ||
- test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
/ok-to-test |
what's the token for? |
It will be used for report code coverage during unit test into coveralls.io 😄 |
The token will be seen for other jobs running on the same cluster. If that's fine to you then I'm happy to add that for you. Or else you can give us a build cluster instead. |
thanks so much for helping 😸 . The coveralls token is not security related, and it'll be fine to be viewed by all k8s jobs 😄 . Can i send you the token on slack or email? |
sure |
(add a secret named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 01189f28f9f5bc8f468bca79034e4e7b6e603f17
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@M00nF1sh: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ref: kubernetes-sigs/aws-load-balancer-controller#706
Ref: #9814