Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HowToMove.md #11

Merged
merged 1 commit into from
Jul 20, 2017
Merged

add HowToMove.md #11

merged 1 commit into from
Jul 20, 2017

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Jul 20, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@apelisse apelisse mentioned this pull request Jul 20, 2017
11 tasks
HOWTOMOVE.md Outdated
@@ -0,0 +1,30 @@
# How To Move a Utility Pkg from Other Kubernetes Repos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you capitalize each word in each titles? :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the conventions is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked at various readme in the project, none of them does that :-/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update it soon.

HOWTOMOVE.md Outdated
## Copy the Pkg to `k8s.io/utils` Repo

Copying should preserve all the git history associated with it.
[Here](http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/) is a working approach.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be very happy to have an example of how you ran it.

Did you run git filter-branch --subdirectory-filter pkg/util/exec -- --all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, then it's simple enough!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to tweak git filter-branch a bit, but I found the way mentioned above is the actually the easiest working approach.
If someone find a better way to do it, we can update this doc :)

@mengqiy
Copy link
Member Author

mengqiy commented Jul 20, 2017

For the file name, should it be HOWTOMOVE.md or HowToMove.md? Or something else?

@apelisse
Copy link
Member

I'd keep it completely upper case, I think that's the convention.

README.md Outdated
@@ -30,3 +30,7 @@ The goal is to keep libraries organized in logical entities.
- [Exec](/exec) provides an interface for `os/exec`. It makes it easier
to mock and replace in tests, especially with
the [FakeExec](exec/testing/fake_exec.go) struct.

## How To Move a Pkg from Other Repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you missed that one :-)

@mengqiy
Copy link
Member Author

mengqiy commented Jul 20, 2017

Updated. PTAL :)

@apelisse
Copy link
Member

Thanks!

@apelisse apelisse merged commit 8e64a09 into kubernetes:master Jul 20, 2017
@mengqiy mengqiy deleted the howTo branch July 20, 2017 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants