-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add HowToMove.md #11
add HowToMove.md #11
Conversation
HOWTOMOVE.md
Outdated
@@ -0,0 +1,30 @@ | |||
# How To Move a Utility Pkg from Other Kubernetes Repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you capitalize each word in each titles? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what the conventions is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked at various readme in the project, none of them does that :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update it soon.
HOWTOMOVE.md
Outdated
## Copy the Pkg to `k8s.io/utils` Repo | ||
|
||
Copying should preserve all the git history associated with it. | ||
[Here](http://gbayer.com/development/moving-files-from-one-git-repository-to-another-preserving-history/) is a working approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be very happy to have an example of how you ran it.
Did you run git filter-branch --subdirectory-filter pkg/util/exec -- --all
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, then it's simple enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to tweak git filter-branch
a bit, but I found the way mentioned above is the actually the easiest working approach.
If someone find a better way to do it, we can update this doc :)
For the file name, should it be |
I'd keep it completely upper case, I think that's the convention. |
README.md
Outdated
@@ -30,3 +30,7 @@ The goal is to keep libraries organized in logical entities. | |||
- [Exec](/exec) provides an interface for `os/exec`. It makes it easier | |||
to mock and replace in tests, especially with | |||
the [FakeExec](exec/testing/fake_exec.go) struct. | |||
|
|||
## How To Move a Pkg from Other Repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you missed that one :-)
Updated. PTAL :) |
Thanks! |
No description provided.