Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform Automated Link Checking Periodically #22489

Open
irvifa opened this issue Jul 13, 2020 · 40 comments
Open

Perform Automated Link Checking Periodically #22489

irvifa opened this issue Jul 13, 2020 · 40 comments
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@irvifa
Copy link
Member

irvifa commented Jul 13, 2020

This is a Feature Request

In order to provide more up to date link checking, it'll be helpful if we can do automated link checking periodically so whenever we found outdated/dead links we can fixed it immediately.

What would you like to be added

To be able to support this, since we already have this Makefile we can try to run this periodically probably using CronJob or other available infrastructure.

Why is this needed

Comments

It'll help us fixed outdated/dead links we can fixed it immediately.

@irvifa
Copy link
Member Author

irvifa commented Jul 13, 2020

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 13, 2020
@irvifa
Copy link
Member Author

irvifa commented Jul 13, 2020

/cc @kubernetes/sig-testing
I included sig-testing here since we will need advice on how to perform periodic test.

@irvifa
Copy link
Member Author

irvifa commented Jul 13, 2020

/cc @kubernetes/sig-docs-en-owners

@BenTheElder
Copy link
Member

https://github.com/kubernetes/test-infra/tree/master/prow#getting-started
periodic job type runs periodically.

@irvifa
Copy link
Member Author

irvifa commented Jul 13, 2020

Thanks @BenTheElder anyway @sftim and @onlydole I’ve checked the periodic jobs on prow https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md however I’m not sure about how often we would like to perform it. Once we agree to the period I’d like to help setup the job.

@sftim
Copy link
Contributor

sftim commented Jul 13, 2020

How about once a week for a proof-of-concept, then the next step would be test every incoming PR (but don't block merges), then we aim to make sure the main branch always passes so we can turn on enforcement for PRs.

?

@sftim
Copy link
Contributor

sftim commented Jul 13, 2020

I think it's (just) fair to label this
/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 13, 2020
@irvifa
Copy link
Member Author

irvifa commented Jul 13, 2020

@sftim Noted then, thank you.

@celestehorgan
Copy link
Contributor

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Jul 15, 2020
@irvifa
Copy link
Member Author

irvifa commented Jul 21, 2020

@BenTheElder Do you know if there's a way to clone this repo to the prow job? I notice that the repo and branch is only tightly coupled with presubmit/postsubmit

@sftim
Copy link
Contributor

sftim commented Aug 9, 2020

/retitle Perform Automated Link Checking Periodically

@k8s-ci-robot k8s-ci-robot changed the title Perform Automated Link Checkeing Periodically Perform Automated Link Checking Periodically Aug 9, 2020
@sftim
Copy link
Contributor

sftim commented Aug 11, 2020

Here's a mockup of how I think the status could show up when link checking fails:
Mockup

@sftim
Copy link
Contributor

sftim commented Aug 11, 2020

(right now I don't know the magic / code to make that happen though, sorry)

@BenTheElder
Copy link
Member

BenTheElder commented Aug 11, 2020 via email

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2020
@onlydole
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 10, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@onlydole
Copy link
Member

onlydole commented Feb 9, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen
Noticed someone else had tried removing this label, not sure why it didn't take

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 2, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 30, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shuuji3
Copy link
Contributor

shuuji3 commented Jan 10, 2023

/reopen
/assign

@k8s-ci-robot
Copy link
Contributor

@shuuji3: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shuuji3
Copy link
Contributor

shuuji3 commented Jan 10, 2023

Hello, I'd like to work on this. 🙂

I already wrote a new GitHub Actions workflow file. The remaining task is only to print out the result as annotation: #22489 (comment)

@shuuji3
Copy link
Contributor

shuuji3 commented Jan 12, 2023

I'm afraid that I'd like to close this issue for now based on the talk on #38866.

/close
/unassign

@k8s-ci-robot
Copy link
Contributor

@shuuji3: Closing this issue.

In response to this:

I'm afraid that I'd like to close this issue for now based on the talk on #38866.

/close
/unassign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Jan 12, 2023

/reopen

It's a valid request even if you don't know how to do this yourself @shuuji3

@k8s-ci-robot k8s-ci-robot reopened this Jan 12, 2023
@k8s-ci-robot
Copy link
Contributor

@sftim: Reopened this issue.

In response to this:

/reopen

It's a valid request even if you don't know how to do this yourself @shuuji3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divya-mohan0209
Copy link
Contributor

/remove-lifecycle rotten
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 15, 2023
@sftim
Copy link
Contributor

sftim commented Dec 30, 2023

Also see #44573

@hunshcn
Copy link
Contributor

hunshcn commented Dec 31, 2023

Another thing is that htmltest doesn't seem to detect cross-page hash. According to my local test results, none of the 19 error of #44573 are detected...
Although checking cross-page hash seems to be supported by htmltest , I use the default configuration under website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/testing Categorizes an issue or PR as relevant to SIG Testing. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.