-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform Automated Link Checking Periodically #22489
Comments
/priority important-longterm |
/cc @kubernetes/sig-testing |
/cc @kubernetes/sig-docs-en-owners |
https://github.com/kubernetes/test-infra/tree/master/prow#getting-started |
Thanks @BenTheElder anyway @sftim and @onlydole I’ve checked the periodic jobs on prow https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md however I’m not sure about how often we would like to perform it. Once we agree to the period I’d like to help setup the job. |
How about once a week for a proof-of-concept, then the next step would be test every incoming PR (but don't block merges), then we aim to make sure the main branch always passes so we can turn on enforcement for PRs. ? |
I think it's (just) fair to label this |
@sftim Noted then, thank you. |
/area web-development |
@BenTheElder Do you know if there's a way to clone this repo to the prow job? I notice that the repo and branch is only tightly coupled with presubmit/postsubmit |
/retitle Perform Automated Link Checking Periodically |
(right now I don't know the magic / code to make that happen though, sorry) |
prow cannot do checks currently, due to not being a github app (and the API
only being available to apps)
…On Tue, Aug 11, 2020 at 11:37 AM Tim Bannister ***@***.***> wrote:
(right now I don't know the magic / code to make that happen though, sorry)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#22489 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK5TLXRUEUT4IPPCE3LSAGFV7ANCNFSM4OYR4F7A>
.
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
@spiffxp: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@shuuji3: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello, I'd like to work on this. 🙂 I already wrote a new GitHub Actions workflow file. The remaining task is only to print out the result as annotation: #22489 (comment) |
I'm afraid that I'd like to close this issue for now based on the talk on #38866. /close |
@shuuji3: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen It's a valid request even if you don't know how to do this yourself @shuuji3 |
@sftim: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
Also see #44573 |
Another thing is that htmltest doesn't seem to detect cross-page hash. According to my local test results, none of the 19 error of #44573 are detected... |
This is a Feature Request
In order to provide more up to date link checking, it'll be helpful if we can do automated link checking periodically so whenever we found outdated/dead links we can fixed it immediately.
What would you like to be added
To be able to support this, since we already have this Makefile we can try to run this periodically probably using CronJob or other available infrastructure.
Why is this needed
Comments
It'll help us fixed outdated/dead links we can fixed it immediately.
The text was updated successfully, but these errors were encountered: