Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockershim deprecation: Private registries support with Containerd #29665

Closed
SergeyKanzhelev opened this issue Sep 10, 2021 · 10 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@SergeyKanzhelev
Copy link
Member

This is a Feature Request

For the dockershim deprecation migration guide this https://kubernetes.io/docs/concepts/containers/images/#configuring-nodes-to-authenticate-to-a-private-registry needs to be updated for other runtimes.

Why is this needed

As dockershim is deprecated, migration guides are needed (see #104878).

KEP: kubernetes/enhancements#2221

/sig node

@SergeyKanzhelev SergeyKanzhelev added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2021
@adisky
Copy link
Contributor

adisky commented Sep 13, 2021

@SergeyKanzhelev I guess the existing docker cfg will work for other container runtimes as well, as credential provider is Kubelet mechanism, if it works only reference of docker runtime needs to be removed from here and need to point the additional available options from container runtimes like https://github.com/containerd/containerd/blob/main/docs/cri/registry.md ?

@SergeyKanzhelev
Copy link
Member Author

@SergeyKanzhelev I guess the existing docker cfg will work for other container runtimes as well, as credential provider is Kubelet mechanism, if it works only reference of docker runtime needs to be removed from here and need to point the additional available options from container runtimes like https://github.com/containerd/containerd/blob/main/docs/cri/registry.md ?

I didn't look deep in creds provider, will it still look for docker config for creds if docker is not installed?

Also we might extend this issue (or maybe create another one) explaining how to configure registry mirrors. If one has it configured for Docker, it is different for other runtimes.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2021

/triage accepted
/priority important-longterm
/language en

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. language/en Issues or PRs related to English language and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 9, 2021
@sftim
Copy link
Contributor

sftim commented Dec 9, 2021

@SergeyKanzhelev would you be willing to open an issue about the mirroring task? I think we should take it at least as far as an issue so we can formally triage it and decide on a course of action.

@SergeyKanzhelev
Copy link
Member Author

Filed: #30843

@chris-short
Copy link
Contributor

How is this issue any different than #30951?

I'm open to splitting up work but this is confusing. Can we capture what we need here and add it to #30951?

@SergeyKanzhelev
Copy link
Member Author

No, this is different. Issue #30951 just updates the information on how to use image pull secret and such. Needs to be updated, but works somehow the same on all runtimes.

What we need specifically for dockershim migration - informaiton on how to translate docker registry settings into containerd registry settings.

Examples:

  • If mirror registry is configured for dockerhub, how to configure the same in containerd
  • if private registry is configured as insecure using docker command line or config file, how to configure the same in containerd
  • if http proxy is set up for the registry using docker-specific config file, how to translate this setting into the containerd setting

Those are typical questions customers have on migration

@KelvinAkpobome
Copy link
Contributor

/assign

@chrisnegus
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@chrisnegus: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants