Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Netris #21440

Closed
wants to merge 5 commits into from
Closed

Adding Netris #21440

wants to merge 5 commits into from

Conversation

asaroyan
Copy link

@asaroyan asaroyan commented Jun 2, 2020

Netris is an automatic netops software with Kubernetes API integration.
We think that community will benefit with this information as Netris software is automating physical networking for the local private Kubernetes clusters.

Netris is an automatic netops software with Kubernetes API integration
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 2, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @asaroyan!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 2, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 2, 2020
@netlify
Copy link

netlify bot commented Jun 3, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 6cc8927

https://deploy-preview-21440--kubernetes-io-master-staging.netlify.app

@asaroyan
Copy link
Author

asaroyan commented Jun 3, 2020

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 3, 2020
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request seems to be to be out of line with the content guide policies on 3rd party content.

/hold

@asaroyan - you might be able to get this approvable if you replace it with a link to 3rd party content and a brief summary. Network plugins are essential for clusters to operate.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2020
@sftim
Copy link
Contributor

sftim commented Jun 3, 2020

It'll be a similar concern for #21456, I imagine.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2020
@asaroyan
Copy link
Author

asaroyan commented Jun 4, 2020

Thanks, edited as per sftim's comment.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who can review this to confirm that Netris is a CNI plugin that fulfils an essential need?

If you can operate a Kubernetes cluster with a lower level network layer deployed and without Netris, I don't think this should merge.

@asaroyan
Copy link
Author

asaroyan commented Jun 4, 2020

Thanks for the comment.
Netris is a physical network orchestration software - like Cisco ACI and Apstra (both included in the list we are trying to merge)
Netris makes physical network to work plug and play with Kubernetes.

Example of essential service:

  • User is exposing a port using "type: load-balancer"
  • Netris automatically configures required L4 load balancing service using it's built-in functionality and allocates a public IP address.

I consider type: load-balancer is an essential function for running a Kubernetes cluster in a local environment. Netris makes it possible.

@thockin
Copy link
Member

thockin commented Jun 15, 2020

I'm OK to have this merge, but I feel the consternation of the docs people here. We don't want kubernetes' website to turn into a bulletin board of advertisements (especially when some of these projects get turned down), but we do want users to be able to find these things,

@asaroyan
Copy link
Author

@thockin, appreciate your support. I think you guys are doing a fantastic job here, and the list will serve well to the best of interest for users. To your point maybe someone should review the list periodically to remove anything turned down, we may be able to help with that.
How to get this merged?

@sftim
Copy link
Contributor

sftim commented Jun 16, 2020

We don't want kubernetes' website to turn into a bulletin board of advertisements (especially when some of these projects get turned down), but we do want users to be able to find these things.

💭 what if https://landscape.cncf.io/category=kubernetes-network-plugin were a thing?

@sftim
Copy link
Contributor

sftim commented Jun 16, 2020

The likely future of content/en/docs/concepts/cluster-administration/networking.md is cleanup as part of the work for #20232

Co-authored-by: Tim Bannister <tim@scalefactory.com>
@asaroyan
Copy link
Author

@sftim - appreciate the suggestion, confirmed (no slogan). The rest I did in analogy to other similar tools (Cisco ACI, Apstra AOS, Big switch networks) - link to company & link to the relevant page describing K8s integration. If requirements change in the future, I commit that we will conform. Can this merge now?

@sftim
Copy link
Contributor

sftim commented Jun 16, 2020

Right now, I don't see how this is something that's useful to link to: the target of the hyperlink is not documentation.

@sftim
Copy link
Contributor

sftim commented Jun 23, 2020

@asaroyan you should update this PR to make it fit in with the content guide.
Otherwise, the next pull request wrangler may close the PR.

@asaroyan
Copy link
Author

@sftim thanks Tim. I'm working on documentation, will update in couple of days. Is that ok?

Added the missing documentation.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign onlydole
You can assign the PR to them by writing /assign @onlydole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sftim
Copy link
Contributor

sftim commented Jul 19, 2020

/close

This PR does not align with the content guide.

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

/close

This PR does not align with the content guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants