-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Netris #21440
Adding Netris #21440
Conversation
Netris is an automatic netops software with Kubernetes API integration
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @asaroyan! |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 6cc8927 https://deploy-preview-21440--kubernetes-io-master-staging.netlify.app |
I signed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request seems to be to be out of line with the content guide policies on 3rd party content.
/hold
@asaroyan - you might be able to get this approvable if you replace it with a link to 3rd party content and a brief summary. Network plugins are essential for clusters to operate.
It'll be a similar concern for #21456, I imagine. |
Thanks, edited as per sftim's comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who can review this to confirm that Netris is a CNI plugin that fulfils an essential need?
If you can operate a Kubernetes cluster with a lower level network layer deployed and without Netris, I don't think this should merge.
Thanks for the comment. Example of essential service:
I consider type: load-balancer is an essential function for running a Kubernetes cluster in a local environment. Netris makes it possible. |
I'm OK to have this merge, but I feel the consternation of the docs people here. We don't want kubernetes' website to turn into a bulletin board of advertisements (especially when some of these projects get turned down), but we do want users to be able to find these things, |
@thockin, appreciate your support. I think you guys are doing a fantastic job here, and the list will serve well to the best of interest for users. To your point maybe someone should review the list periodically to remove anything turned down, we may be able to help with that. |
💭 what if https://landscape.cncf.io/category=kubernetes-network-plugin were a thing? |
The likely future of |
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@sftim - appreciate the suggestion, confirmed (no slogan). The rest I did in analogy to other similar tools (Cisco ACI, Apstra AOS, Big switch networks) - link to company & link to the relevant page describing K8s integration. If requirements change in the future, I commit that we will conform. Can this merge now? |
Right now, I don't see how this is something that's useful to link to: the target of the hyperlink is not documentation. |
@asaroyan you should update this PR to make it fit in with the content guide. |
@sftim thanks Tim. I'm working on documentation, will update in couple of days. Is that ok? |
Added the missing documentation.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/close This PR does not align with the content guide. |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Netris is an automatic netops software with Kubernetes API integration.
We think that community will benefit with this information as Netris software is automating physical networking for the local private Kubernetes clusters.