-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder for Built-in Defaulting #24640
Conversation
Deploy preview for kubernetes-io-vnext-staging processing. Building with commit 1608dd7 https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f8db202c2580e0007e1fcd5 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apelisse The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone 1.20 |
/sig api-machinery |
/assign @reylejano-rxm |
/hold cancel |
hi @apelisse with k/k merged, please take some time to fill out the docs content to make sure this gets reviewed before the deadline. Once it's ready, please change the stage of PR from draft to ready for review. |
k/k's not merged, there are still several PRs that need to be merged and orchestrated. We're still confident we'll do it in time though. |
Ah okay! thanks for the clarification. We were only tracking kubernetes/kubernetes#95423 and wasn't aware of other PRs. Please remove the hold when all relevant PRs have been merged! Thank you /hold |
Hi @apelisse The earlier you can provide some content, the earlier that SIG Docs can get reviewing. We'd really appreciate a chance to get as much reviewing done as we can before KubeCon. |
Thanks, that's great to know, we'll get started asap. We're still mostly rushing through for code-freeze, but I'll see what we can do. |
Note: Exception filed (pending approval) |
/hold |
/hold cancel |
Hi @apelisse, please keep in mind that the Docs PR Ready for Review deadline is around the corner on Monday, November 23 |
looks like another PR was open to replace this PR #25151 /milestone clear |
@annajung: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Place-holder pull-request (for now) for built-in defaulting (kubernetes/enhancements#1929).