Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder for Built-in Defaulting #24640

Closed
wants to merge 1 commit into from

Conversation

apelisse
Copy link
Member

Place-holder pull-request (for now) for built-in defaulting (kubernetes/enhancements#1929).

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 1608dd7

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f8db202c2580e0007e1fcd5

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apelisse
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@reylejano
Copy link
Member

/milestone 1.20

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 19, 2020
@sftim sftim marked this pull request as draft October 20, 2020 11:40
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2020
@reylejano
Copy link
Member

reylejano commented Oct 27, 2020

/sig api-machinery
/hold pending merge of kubernetes/kubernetes#95423

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 27, 2020
@annajung
Copy link
Contributor

annajung commented Nov 5, 2020

/assign @reylejano-rxm

@annajung
Copy link
Contributor

annajung commented Nov 9, 2020

/hold cancel
k/k merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2020
@annajung
Copy link
Contributor

annajung commented Nov 9, 2020

hi @apelisse with k/k merged, please take some time to fill out the docs content to make sure this gets reviewed before the deadline. Once it's ready, please change the stage of PR from draft to ready for review.

@apelisse
Copy link
Member Author

apelisse commented Nov 9, 2020

k/k's not merged, there are still several PRs that need to be merged and orchestrated. We're still confident we'll do it in time though.

@annajung
Copy link
Contributor

annajung commented Nov 9, 2020

Ah okay! thanks for the clarification. We were only tracking kubernetes/kubernetes#95423 and wasn't aware of other PRs. Please remove the hold when all relevant PRs have been merged! Thank you

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2020
@sftim
Copy link
Contributor

sftim commented Nov 10, 2020

Hi @apelisse

The earlier you can provide some content, the earlier that SIG Docs can get reviewing. We'd really appreciate a chance to get as much reviewing done as we can before KubeCon.

@apelisse
Copy link
Member Author

Thanks, that's great to know, we'll get started asap. We're still mostly rushing through for code-freeze, but I'll see what we can do.

@annajung
Copy link
Contributor

Note:

Exception filed (pending approval)

@annajung
Copy link
Contributor

/hold

@annajung
Copy link
Contributor

/hold cancel
exception approved, k/k merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@reylejano
Copy link
Member

Hi @apelisse, please keep in mind that the Docs PR Ready for Review deadline is around the corner on Monday, November 23

@annajung
Copy link
Contributor

looks like another PR was open to replace this PR #25151

/milestone clear
/close

@k8s-ci-robot k8s-ci-robot removed this from the 1.20 milestone Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

@annajung: Closed this PR.

In response to this:

looks like another PR was open to replace this PR #25151

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants