Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in API Types Defaults #1929

Closed
apelisse opened this issue Aug 7, 2020 · 30 comments
Closed

Built-in API Types Defaults #1929

apelisse opened this issue Aug 7, 2020 · 30 comments
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.

Comments

@apelisse
Copy link
Member

apelisse commented Aug 7, 2020

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 7, 2020
@apelisse
Copy link
Member Author

apelisse commented Aug 7, 2020

/sig api-machinery
/wg api-expression

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. wg/api-expression Categorizes an issue or PR as relevant to WG API Expression. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi @apelisse

Enhancements Lead here. Could you clarify your plans for 1.20? Above it says beta but in the kep.yaml in #1928 it says that 1.20 is stable.

Thanks!
Kirsten

@apelisse
Copy link
Member Author

apelisse commented Sep 14, 2020

Thanks, I will, we're planning beta in 1.20

@apelisse
Copy link
Member Author

apelisse commented Sep 14, 2020

Updated!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 14, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice kikisdeliveryservice added stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 14, 2020
@kinarashah
Copy link

kinarashah commented Sep 27, 2020

Hi @apelisse,

Enhancement shadow for 1.20 release here 👋.

I see that your KEP PR is under review, just wanted to remind you that the Enhancement freeze deadline for KEPs to be included in 1.20 milestone is Tuesday, October 6.

We're looking for the KEP PR to have the following before this deadline:

  • should have test plans
  • should have graduation criteria
  • should have state implementable and merged

Please let me know if you have any questions, thank you!

@kinarashah
Copy link

kinarashah commented Oct 2, 2020

Thank you @apelisse for actively working on the KEP PR!

Here's the status update based on the freeze requirements:

Requirement Status Comments
Test Plan does this comment need to be addressed?
Graduation Criteria Updated to - As an internal feature, this will go straight to stable.
Implementable State -
Merged 🏁 ℹ️ Approved by lavalamp, yet to be merged

Just a friendly reminder that we'd need all of them with status to be included in 1.20 milestone by Enhancement Freeze deadline Tuesday, October 6.

Thank you!!

@apelisse
Copy link
Member Author

apelisse commented Oct 5, 2020

Thanks, I think I've addressed the test plan comment, and I'm now waiting for this PR to be merged!

@kinarashah
Copy link

kinarashah commented Oct 5, 2020

Thank you @apelisse for the update, that sounds great! 🚢

@kinarashah
Copy link

kinarashah commented Oct 12, 2020

Hi @apelisse,

Since this Enhancement is scheduled to be in 1.20, please keep in mind these important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thank you!

@reylejano
Copy link
Member

reylejano commented Oct 19, 2020

Hello @apelisse , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against the dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th.

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@apelisse
Copy link
Member Author

apelisse commented Oct 19, 2020

Created :-) Thanks!

@reylejano
Copy link
Member

reylejano commented Nov 1, 2020

Hi @apelisse

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Hi @apelisse

I don't see any k/k prs attached to this issue? Can you update with the status?

Just a reminder that Code Freeze is coming up tomorrow on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

Thanks
Kirsten

@apelisse
Copy link
Member Author

apelisse commented Nov 11, 2020

We're still working on it, thanks :-)

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Thanks! please link the prs to this issue once they are up.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

As per: kubernetes/website#24640 (comment)

One PR has merged(kubernetes/kubernetes#95423) but we are waiting for some others, and author will link them to issue once they are up.

@apelisse
Copy link
Member Author

apelisse commented Nov 12, 2020

There's one, but it's failing because test-infra seems to be failing: kubernetes/kubernetes#96480
And then there's this: kubernetes/gengo#192
which is partly integrated here: kubernetes/kubernetes#96317

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 12, 2020

Just to confirm, for k/k prs this requires:

@apelisse
Copy link
Member Author

apelisse commented Nov 12, 2020

The last PR is just the integration of kubernetes/gengo#192, it should move super fast.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

Hi @apelisse

Code Freeze is now in effect. You have 2 PRs that are still unmerged (one with a hold, both missing LGTMs). If you believe this should be in the 1.20 Release, please file an Exception.

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Nov 13, 2020
@kikisdeliveryservice kikisdeliveryservice added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 13, 2020
@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Nov 13, 2020
@Jefftree
Copy link
Member

Jefftree commented Nov 13, 2020

@kikisdeliveryservice kikisdeliveryservice added this to the v1.20 milestone Nov 13, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Nov 13, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

Exception granted: https://groups.google.com/g/kubernetes-sig-release/c/eCk4Xyb58GQ/m/tjgEstjyAQAJ

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 13, 2020

kubernetes/kubernetes#96480 & kubernetes/kubernetes#96317 both need a rebase now 😦

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 14, 2020

Looks like both prs have now merged!! 🎆

@verdverm
Copy link

verdverm commented Dec 2, 2020

Curious, why weren't Go struct tags used for this?

@apelisse
Copy link
Member Author

apelisse commented Dec 2, 2020

In general, I think we're moving away from these. I can see why the are useful (they can be parsed at runtime), but they are also very hard to read, especially when we start to have many of these.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@lavalamp
Copy link
Member

lavalamp commented Jan 13, 2021

@apelisse do you want this for 1.21?

@apelisse
Copy link
Member Author

apelisse commented Jan 13, 2021

No, this is already stable :-)

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 13, 2021

@apelisse: Closing this issue.

In response to this:

No, this is already stable :-)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/api-expression Categorizes an issue or PR as relevant to WG API Expression.
Projects
None yet
Development

No branches or pull requests

9 participants