Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on Built-in Defaulting #25151

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

Jefftree
Copy link
Member

kubernetes/enhancements#1929

This PR will be used in place of #24640.

Add section for how defaulting interacts with nullable fields for CRDs.

/cc @apelisse

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Nov 21, 2020

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 3dc68c9

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5fbbe8266b175b0007a0320e

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 21, 2020
@annajung
Copy link
Contributor

/milestone 1.20
/assign @reylejano-rxm
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 23, 2020
@annajung
Copy link
Contributor

Hi @Jefftree please make sure the state of this PR is changed to ready for review by eod 5pm pst today.

@Jefftree Jefftree force-pushed the defaults branch 2 times, most recently from 03695b3 to 732bfca Compare November 23, 2020 16:35
@Jefftree Jefftree marked this pull request as ready for review November 23, 2020 16:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2020
@apelisse
Copy link
Member

That's very clear to me, and accurate :-) Thanks!
LGTM

Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b40b3684ac096038c5f69d2528f01dd0a46addf2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irvifa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 41024ed into kubernetes:dev-1.20 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants