Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Memory Manager official documentation #24642

Closed
wants to merge 1 commit into from

Conversation

cezaryzukowski
Copy link

WIP

Signed-off-by: Cezary Zukowski <c.zukowski@samsung.com>
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit 9ccd0ca

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5f8dbe54a237100007f29a9d

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @cezaryzukowski!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cezaryzukowski
To complete the pull request process, please assign celestehorgan after the PR has been reviewed.
You can assign the PR to them by writing /assign @celestehorgan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 19, 2020
@cezaryzukowski
Copy link
Author

/milestone 1.20

@k8s-ci-robot
Copy link
Contributor

@cezaryzukowski: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cezaryzukowski
Copy link
Author

@kbhawkey @kbarnard10 Hi, could you add it to the milestone 1.20? (only maintainers are allowed to do it via "/milestone 1.20")

Thanks in advance. Cheers.

@annajung
Copy link
Contributor

/milestone 1.20
/assign @eagleusb @annajung

@k8s-ci-robot k8s-ci-robot added this to the 1.20 milestone Oct 19, 2020
@annajung
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 19, 2020
@annajung
Copy link
Contributor

/hold
until k/k PR (kubernetes/kubernetes#95479) is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2020
@sftim sftim marked this pull request as draft October 21, 2020 10:36
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2020
@sftim
Copy link
Contributor

sftim commented Oct 21, 2020

This is a placeholder PR.

marked as draft.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cezaryzukowski

Here's some early feedback

In order to extract the best performance, optimizations related to CPU isolation, memory and device locality are required. However, in Kubernetes, these optimizations are handled by a disjoint set of components.
-->

The *Memory Manager* is a new component in *kubelet* ecosystem, and it enables the feature of guaranteed memory (and hugepages) allocation for pods in Guaranteed QoS class. The feature offers a couple of allocation strategies. The first one, the *single-NUMA* strategy, is intended for high-performance and performance-sensitive applications. The second one, the *multi-NUMA* strategy, complements the overall design while it overcomes the situation that cannot be managed with the *single-NUMA* strategy. Namely, whenever the amount of memory demanded by a pod is in the excess of a single NUMA node capacity, the guaranteed memory is provisioned across multiple NUMA nodes with the *multi-NUMA* strategy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The *Memory Manager* is a new component in *kubelet* ecosystem, and it enables the feature of guaranteed memory (and hugepages) allocation for pods in Guaranteed QoS class. The feature offers a couple of allocation strategies. The first one, the *single-NUMA* strategy, is intended for high-performance and performance-sensitive applications. The second one, the *multi-NUMA* strategy, complements the overall design while it overcomes the situation that cannot be managed with the *single-NUMA* strategy. Namely, whenever the amount of memory demanded by a pod is in the excess of a single NUMA node capacity, the guaranteed memory is provisioned across multiple NUMA nodes with the *multi-NUMA* strategy.
The *Memory Manager* enables the feature of guaranteed memory (and hugepages) allocation for pods in the Guaranteed [QoS class](/docs/tasks/configure-pod-container/quality-service-pod/#qos-classes). You can select from two memory allocation strategies. The first one, the *single-NUMA* strategy, is intended for high-performance and performance-sensitive applications. The second one, the *multi-NUMA* strategy, complements the overall design while it overcomes the situation that cannot be managed with the *single-NUMA* strategy.
With the *multi-NUMA* strategy, whenever the amount of memory demanded by a pod is in the excess of a single NUMA node capacity, the guaranteed memory is provisioned across multiple NUMA nodes


`--feature-gates=MemoryManager=true`

### Memory Manager Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
### Memory Manager Configuration
### Memory Manager configuration


Notice that both CPU and memory requests must be specified for a Pod to lend it to Guaranteed QoS class.

### The Reserved Memory Flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### The Reserved Memory Flag
### Reserved memory flag

Comment on lines +144 to +148
### Known Limitations

- See [the limitations of Topology Manager](/docs/tasks/administer-cluster/topology-manager/#known-limitations).

TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be OK to omit this?

@annajung annajung removed their assignment Nov 11, 2020
@annajung
Copy link
Contributor

Hi @cezaryzukowski

Friendly reminder that docs ready for review deadline is coming up on Nov 23rd, right after Kubecon NA. We would appreciate it if you could provide most of the doc content for this feature early so that it can be reviewed by Sig Docs before Kubecon and other events happening in November.

When it's ready to be reviewed, please don't forget to change the stage from draft to ready to be reviewed. Thank you!

@annajung
Copy link
Contributor

Note:
except request granted.
k/k pr will merge after code freeze deadline

@cezaryzukowski
Copy link
Author

@annajung We will provide update ASAP.

@annajung
Copy link
Contributor

Hi @cezaryzukowski based on kubernetes/enhancements#1769 (comment) and kubernetes/kubernetes#95479 (comment), it looks like this will be deferred to 1.21.

Please feel free to reopen this pr against the future release branch when it's available.

/milestone clear
/close

@k8s-ci-robot k8s-ci-robot removed this from the 1.20 milestone Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

@annajung: Closed this PR.

In response to this:

Hi @cezaryzukowski based on kubernetes/enhancements#1769 (comment) and kubernetes/kubernetes#95479 (comment), it looks like this will be deferred to 1.21.

Please feel free to reopen this pr against the future release branch when it's available.

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cezaryzukowski
Copy link
Author

Hi @cezaryzukowski

Here's some early feedback

Hi @sftim @annajung, many thanks for initial feedback. I applied your suggestions.
Although Memory Manager will be deferred to v1.21, I completed the final draft: https://github.com/cezaryzukowski/website/tree/dev-1.20
So that we have it almost ready for v1.21.
See you soon, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants