Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTLAfterFinished feature reference #28112

Conversation

chuntaochen
Copy link
Contributor

update the reference to indicate that TTLAfterFinished graduated to beta in zh doc
Ref:
pr en #28011
kubernetes/enhancements#592

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 25, 2021
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label May 25, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign chenrui333 after the PR has been reviewed.
You can assign the PR to them by writing /assign @chenrui333 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2021
@netlify
Copy link

netlify bot commented May 25, 2021

Deploy Preview for kubernetes-io-master-staging ready!

Built with commit db651df

https://deploy-preview-28112--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented May 25, 2021

Deploy Preview for kubernetes-io-master-staging ready!

Built with commit 83f226e

https://deploy-preview-28112--kubernetes-io-master-staging.netlify.app

Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢贡献。根据汉化约定约定,我们会拒绝对页面的部分修改。部分修改针对的是对应页面的英文上游还有其他改动需要同步的情况。
一旦我们合并了此 PR,将来就无法根据文件的最后更改时间来判断是否有其他上游变更尚未同步。请理解。
请在 master 分支上执行以下命令查看上游尚未同步的更改:

./scripts/lsync.sh content/zh/docs/reference/command-line-tools-reference/feature-gates.md

@chuntaochen
Copy link
Contributor Author

谢谢贡献。根据汉化约定约定,我们会拒绝对页面的部分修改。部分修改针对的是对应页面的英文上游还有其他改动需要同步的情况。
一旦我们合并了此 PR,将来就无法根据文件的最后更改时间来判断是否有其他上游变更尚未同步。请理解。
请在 master 分支上执行以下命令查看上游尚未同步的更改:

./scripts/lsync.sh content/zh/docs/reference/command-line-tools-reference/feature-gates.md

多谢提醒,之前不清楚相关规定

@chuntaochen
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@chuntaochen: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants