Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node problem detector to add-ons #29719

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Sep 15, 2021

Add https://github.com/kubernetes/node-problem-detector to the list of add-ons.

/sig node
/language en

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 15, 2021
@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: c0c3d04

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61a27b107bd2770008b81524

😎 Browse the preview: https://deploy-preview-29719--kubernetes-io-main-staging.netlify.app

@RinkiyaKeDad
Copy link
Member

@kubernetes/sig-node-pr-reviews can we please get a review on this?

@sftim sftim force-pushed the 20210915_document_node_problem_detector_add_on branch from d50a952 to 4c3ee18 Compare September 30, 2021 09:53
@sftim sftim force-pushed the 20210915_document_node_problem_detector_add_on branch from 4c3ee18 to c0c3d04 Compare November 27, 2021 18:38
@jimangel
Copy link
Member

jimangel commented Dec 6, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c6e3a9158412fc39bfd630d5d86b877efe8c6d9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimangel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1b95b8b into kubernetes:main Dec 6, 2021
@sftim sftim deleted the 20210915_document_node_problem_detector_add_on branch December 8, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants