Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Update concepts/cluster-administration/addons.md #34752

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 1, 2022
@netlify
Copy link

netlify bot commented Jul 1, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e9b460c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62beb8c71517dc0008960cb2
😎 Deploy Preview https://deploy-preview-34752--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

2 similar comments
@netlify
Copy link

netlify bot commented Jul 1, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e9b460c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62beb8c71517dc0008960cb2
😎 Deploy Preview https://deploy-preview-34752--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 1, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e9b460c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62beb8c71517dc0008960cb2
😎 Deploy Preview https://deploy-preview-34752--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 1, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ec0c846
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62c2c79b037e2b000897f949
😎 Deploy Preview https://deploy-preview-34752--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@t-inu t-inu marked this pull request as ready for review July 1, 2022 09:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bells17 July 1, 2022 09:30
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
Copy link
Contributor

@s-kawamura-w664 s-kawamura-w664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost no problem.
I commented on one point.

@@ -44,6 +45,7 @@ content_type: concept
## インフラストラクチャ

* [KubeVirt](https://kubevirt.io/user-guide/#/installation/installation)は仮想マシンをKubernetes上で実行するためのアドオンです。通常、ベアメタルのクラスタで実行します。
* [node problem detector](https://github.com/kubernetes/node-problem-detector)はLinuxノード上で動作し、システムの問題を[Events](/docs/reference/kubernetes-api/cluster-resources/event-v1/)または[ノードのCondition](/ja/docs/concepts/architecture/nodes/#condition)として報告します。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [node problem detector](https://github.com/kubernetes/node-problem-detector)はLinuxノード上で動作し、システムの問題を[Events](/docs/reference/kubernetes-api/cluster-resources/event-v1/)または[ノードのCondition](/ja/docs/concepts/architecture/nodes/#condition)として報告します。
* [node problem detector](https://github.com/kubernetes/node-problem-detector)はLinuxノード上で動作し、システムの問題を[Event](/docs/reference/kubernetes-api/cluster-resources/event-v1/)または[ノードのCondition](/ja/docs/concepts/architecture/nodes/#condition)として報告します。

I think "Event" would be better as above.

  1. The following is the localization rule. (https://kubernetes.io/ja/docs/contribute/localization/)
    また、日本語では名詞を複数形にする意味はあまりないので、
    英語の名詞を利用する場合は原則として単数形で表現してください。
    
  2. Linked site's title is "Event".
  3. In English's following site, "Event" is used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@s-kawamura-w664
Copy link
Contributor

Thanks for the update. It is so good.
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57047b627c036941a7506ff1f76d6e4a775b70a8

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5a1c17a into kubernetes:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] concepts/cluster-administration/addons might be outdated
4 participants