Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] fixed Wrong Korean translations #30287

Closed
wants to merge 1 commit into from
Closed

[ko] fixed Wrong Korean translations #30287

wants to merge 1 commit into from

Conversation

suhhee1011
Copy link

This Pull request is about fixed issue #29027.

I changed the Wrong translation in 3 files.

  1. ko/docs/concepts/workloads/pods/pod-lifecycle.md
  2. ko/docs/tutorials/stateful-application/basic-stateful-set.md
  3. ko/docs/concepts/scheduling-eviction/taint-and-toleration.md

Please let me know if there is more place to edit the wrong translation.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ianychoi after the PR has been reviewed.
You can assign the PR to them by writing /assign @ianychoi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 28, 2021
@suhhee1011
Copy link
Author

suhhee1011 commented Oct 28, 2021 •
edited

I signed on CLA agreement

@suhhee1011 suhhee1011 mentioned this pull request Oct 28, 2021
Closed
@netlify
Copy link

netlify bot commented Oct 28, 2021 •
edited

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 640cfa1

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/617b195a5afed900088ac899

😎 Browse the preview: https://deploy-preview-30287--kubernetes-io-main-staging.netlify.app

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 28, 2021
@AvineshTripathi
Copy link
Contributor

@suhhee1011 Thank you for contributing can you check if you have signed the CLA correctly link

@suhhee1011
Copy link
Author

suhhee1011 commented Oct 28, 2021 •
edited

Hi @AvineshTripathi , I just signed the CLA agreement :) Can you please recheck it?

@suhhee1011
Copy link
Author

/check-cla

@suhhee1011
Copy link
Author

I signed it

@suhhee1011
Copy link
Author

/assign

@suhhee1011
Copy link
Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 28, 2021
@seokho-son
Copy link
Member

@suhhee1011
Welcome to Korean localization !! :) I am SIG-Docs Korean localization team lead.

We have a special~ development branch for Korean localization based on a milestone strategy :)

Currently, it is dev.1.22-ko.2 (https://github.com/kubernetes/website/tree/dev-1.22-ko.2)
Please take a look the notices for dev-1.22-ko.2 branch #29999

So, could you rebase the base branch and target branch to dev-1.22-ko.2 branch ?

Also, I'd like to introduce Slack channel for #kubernetes-docs-ko

Thank you for the contribution.

@seokho-son
Copy link
Member

/retitle [ko] fixed Wrong Korean translations

@k8s-ci-robot k8s-ci-robot changed the title fixed Wrong Korean translations [ko] fixed Wrong Korean translations Oct 29, 2021
@AvineshTripathi
Copy link
Contributor

Hi @AvineshTripathi , I just signed the CLA agreement :) Can you please recheck it?

Thank you for signing and contributing 😄

@jihoon-seo
Copy link
Member

@suhhee1011 Thank you for your interest and contribution for this project!

보통 assign은 reviewer/approver 를 하는 것 같아서, @suhhee1011 님 자신을 assign 하신 것은 해제하겠습니다. 😊
/unassign @suhhee1011

Previews:

jihoon-seo
jihoon-seo reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suhhee1011 기여 감사합니다~~
커멘트를 작성해 보았습니다. 😊
PTAL!

content/ko/docs/tutorials/stateful-application/basic-stateful-set.md
@@ -122,7 +122,7 @@ web-1 1/1 Running 0 18s
```

참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계-phase) 참고)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계-phase) 참고)
참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계) 참고)

content/ko/docs/tutorials/stateful-application/basic-stateful-set.md
@@ -122,7 +122,7 @@ web-1 1/1 Running 0 18s
```

참고로 `web-1` 파드는 `web-0` 파드가 _Running_ ([파드의 단계](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-단계-phase) 참고)
및 _Ready_ ([파드의 조건](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-조건-condition)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자.
및 _Ready_ ([파드의 컨디션](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-컨디션-condition)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
및 _Ready_ ([파드의 컨디션](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-컨디션-condition)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자.
및 _Ready_ ([파드의 컨디션](/ko/docs/concepts/workloads/pods/pod-lifecycle/#파드의-컨디션)에서 `type` 참고) 상태가 되기 전에 시작하지 않음을 주의하자.

@seokho-son
Copy link
Member

/assign @jihoon-seo
신규 컨트리뷰터의 PR, 잘 가이드 해주시길 부탁 드립니다.. :)

@jihoon-seo jihoon-seo mentioned this pull request Nov 1, 2021
Closed
@seokho-son
Copy link
Member

seokho-son commented Nov 9, 2021 •
edited

@suhhee1011
한글화 작업 브랜치가 변경되었습니다.. ^^
dev-1.22-ko.2 -> dev-1.22-ko.3

신규 마일스톤 공지
#30413

@ianychoi
Copy link
Contributor

@suhhee1011 Thank you for your first contribution for Korean localization! Feel free to ask in Korean / English, or you can come to Korean Docs regular meeting if you would like to ask in details. Looking forward to your updates with @jihoon-seo 's guidance thank you both and all

@ianychoi ianychoi removed their request for review November 13, 2021 06:01
@jihoon-seo jihoon-seo mentioned this pull request Jan 17, 2022
Merged
@jihoon-seo
Copy link
Member

Closing due to author not responding to comments or feedback in 2 or more weeks,
and covered by the PR #31365.

/close

@k8s-ci-robot
Copy link
Contributor

@jihoon-seo: Closed this PR.

In response to this:

Closing due to author not responding to comments or feedback in 2 or more weeks,
and covered by the PR #31365.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo left review comments

@yoonian yoonian Awaiting requested review from yoonian

Assignees

@jihoon-seo jihoon-seo

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@suhhee1011 @k8s-ci-robot @k8s-triage-robot @AvineshTripathi @seokho-son @jihoon-seo @ianychoi