Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Clean up various broken links #32917

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

tallclair
Copy link
Member

Clean up broken links reported through the HackerOne bug bounty program.

Localized version of #32783

/committee security-response

@k8s-ci-robot k8s-ci-robot added committee/security-response Denotes an issue or PR intended to be handled by the product security committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 0f087d5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/625765989f77770008d5ad21
😎 Deploy Preview https://deploy-preview-32917--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

seokho-son commented Apr 14, 2022

Hi @tallclair
Thank you for the contribution.

I have a question regarding Contiv.

https://github.com/kubernetes/website/pull/32917/files#diff-1e3d7eea6e6ef57fce9ac297762d24e73c02b1e441fa4b0fe6ad662831ea43a0R24

* [Contiv](https://contivpp.io/)는 다양한 유스케이스와 풍부한 폴리시 프레임워크를 위해 구성 가능한 네트워킹(BGP를 사용하는 네이티브 L3, vxlan을 사용하는 오버레이, 클래식 L2 그리고 Cisco-SDN/ACI)을 제공한다. Contiv 프로젝트는 완전히 [오픈소스](https://github.com/contiv)이다. [인스톨러](https://github.com/contiv/install)는 kubeadm을 이용하거나, 그렇지 않은 경우에 대해서도 설치 옵션을 모두 제공한다.

This change is not aligned with English document (the HEAD of main branch).
There is no description for Contiv in
https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/cluster-administration/addons.md


I checked PR history regarding en/docs/concepts/cluster-administration/addons.md.

The line for Contiv in English document has been removed by your PR (#31760).
Also the line for Contiv in Korean document has been removed by PR (#32782), but this PR restore the line for Contiv in Korean document.

@tallclair Could you check #31760 includes a mistake (removing the line instead of changing URL).
If it is a mistake, please update English document first.
(PTAL @reylejano . if we need to take care anything regarding this issue)

@seokho-son
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2022
@tallclair
Copy link
Member Author

@seokho-son thanks for flagging that. I added it back in #32938

@seokho-son
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2022
@seokho-son
Copy link
Member

Thanks! :)

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 076e754c964428da91bf308eba34994a77aaf548

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 255899a into kubernetes:main Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants