Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Contiv addon link. #32938

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Fix Contiv addon link. #32938

merged 2 commits into from
Apr 14, 2022

Conversation

tallclair
Copy link
Member

Rollback #31760 and provide the correct link rather than deleting the entry.

If we'd prefer to leave it deleted, I can update the translations that way instead.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 14, 2022
@tallclair tallclair mentioned this pull request Apr 14, 2022
Closed
@tallclair
Copy link
Member Author

Hmm, this is a bit of a mess, since some of the localizations have removed contiv but not all. Please let me know what you'd like to do here.

@sftim
Copy link
Contributor

sftim commented Apr 14, 2022

/lgtm

We always prefer to have localizations pull changes from upstream; direct changes to localizations aren't supposed to be a thing.

Linking to Contiv VPP seems OK.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a8482d53acfffe77f5112e25fcd8a5b940e98872

@sftim
Copy link
Contributor

sftim commented Apr 14, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 2dbbadd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6258511b25209500081eadd0
😎 Deploy Preview https://deploy-preview-32938--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot merged commit 165fcc8 into kubernetes:main Apr 14, 2022
ydFu added a commit to ydFu/website that referenced this pull request Apr 15, 2022
@ydFu
[zh] Sync cluster-administration pages for addons.md
e9951bb 
* Sync with english version in 'Fix Contiv addon link.' (kubernetes#32938)

Signed-off-by: ydFu <ader.ydfu@gmail.com>
@ydFu ydFu mentioned this pull request Apr 15, 2022
Merged
ydFu added a commit to ydFu/website that referenced this pull request Apr 15, 2022
@ydFu
[zh] Sync cluster-administration pages for addons.md
5061591 
* Sync with english version in 'Fix Contiv addon link.' (kubernetes#32938)

Signed-off-by: ydFu <ader.ydfu@gmail.com>
@tallclair tallclair mentioned this pull request Apr 15, 2022
Merged
@reylejano reylejano mentioned this pull request Jun 8, 2022
Merged
@t-inu t-inu mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tallclair @sftim @k8s-ci-robot