Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Installing kubeadm topic. #3709

Merged
merged 5 commits into from
Jun 2, 2017
Merged

Create Installing kubeadm topic. #3709

merged 5 commits into from
Jun 2, 2017

Conversation

steveperry-53
Copy link
Contributor

@steveperry-53 steveperry-53 commented May 10, 2017

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2017
@steveperry-53
Copy link
Contributor Author

@bgrant0607, Can you comment on whether you think this PR is heading in the right direction? The last time you and I met, we discussed the idea of having a set of Tasks for installing tools like kubectl, minikube, kubeadm, helm, etc. I like the idea putting tool installation in its own section. But on the other hand, I'm concerned about factoring tool installation out of Setup topics like Installing Kubernetes on Linux with kubeadm. I really don't want to duplicate the installation instructions for a given tool, so I think we should choose one approach or the other.

cc @mikedanese, @luxas, @errordeveloper, @jbeda

@bgrant0607
Copy link
Member

@steveperry-53 Creating a kubeadm installation task makes sense to me. I could imagine someone wanting to know just that. Is the concern that it would only be referenced by the guide that explains how to use kubeadm to create a cluster? I expect to have multiple kubeadm-related guides, for creating different types of clusters, updating clusters, etc.

@steveperry-53
Copy link
Contributor Author

@bgrant0607 My concern is about where to put the How to Install kubeadm topic. In the top nav, we have a Setup, Concepts, Tasks, ... I'm thinking that How to Install kubeadm should not be under Tasks. Instead it should be under Setup, along with the other topics that talk about how to use kubeadm to create/update clusters.

@bgrant0607
Copy link
Member

@steveperry-53

Installing anything (kubeadm, kubectl, etc.) is probably "Setup".

However, we want to make docs easy to find.

Is it not possible to list the topic under multiple categories?

@steveperry-53
Copy link
Contributor Author

@bgrant0607 OK, we'll put the Installing topics under Setup. I'll look into listing topics in multiple places. I think we can do that.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 2, 2017
@steveperry-53 steveperry-53 merged commit 57385e8 into kubernetes:master Jun 2, 2017
@steveperry-53 steveperry-53 deleted the kubeadm branch June 2, 2017 01:07
chenopis added a commit that referenced this pull request Jun 2, 2017
chenopis added a commit that referenced this pull request Jun 2, 2017
…hub.io into release-1.6

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Improve RBAC doc (#3951)
  Clarify CNI acronym
  Fix 404 to kubectl install link
  install-kubectl.md: Fix Windows texts, link to latest macOS binaries
  Create Installing kubeadm topic. (#3709)
chenopis added a commit to iphutch/kubernetes.github.io that referenced this pull request Jun 26, 2017
…hub.io

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (859 commits)
  fixed the line giving the template for creating configmap, should include the word configmap as part of the creation process.
  Fixes issue kubernetes#3939
  Add CRI runtime support
  Updaated install-kubeadm.md, removed redundant kubectl installation (kubernetes#4006)
  Add Chocolatey Package Manager for Windows (kubernetes#4000)
  Make issue title automatically a link
  Update directions for macOS bash completion
  Add TCP socket health check example (kubernetes#3977)
  Update networking.md (kubernetes#3950)
  [authorization] fix invalid href for webhook
  Remove self-referential link
  Add fibre channel volume explanation (kubernetes#3967)
  Improve RBAC doc (kubernetes#3951)
  Clarify CNI acronym
  Fix 404 to kubectl install link
  install-kubectl.md: Fix Windows texts, link to latest macOS binaries
  Create Installing kubeadm topic. (kubernetes#3709)
  Fix example in the "Adding ConfigMap data to a Volume" section
  Update ExternalName example
  Completes PR kubernetes#3325
  ...

# Conflicts:
#	_data/tasks.yml
#	docs/tasks/administer-cluster/namespaces-walkthrough.md
#	docs/tasks/administer-cluster/namespaces.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants