Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update networking.md #3950

Merged
merged 8 commits into from
Jun 5, 2017
Merged

Update networking.md #3950

merged 8 commits into from
Jun 5, 2017

Conversation

kshafiee
Copy link
Contributor

@kshafiee kshafiee commented May 31, 2017

Added CNI-Genie as one of the many options

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.


This change is Reviewable

Added CNI-Genie as one of the many options
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2017
@kshafiee
Copy link
Contributor Author

@chenopis any ideas who would be the best person to review this PR? Thx!

@chenopis chenopis self-assigned this May 31, 2017
@chenopis chenopis requested a review from thockin May 31, 2017 22:16
Copy link
Contributor

@chenopis chenopis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grammar nit.

@@ -223,6 +223,12 @@ Weave Net runs as a [CNI plug-in](https://www.weave.works/docs/net/latest/cni-pl
or stand-alone. In either version, it doesn't require any configuration or extra code
to run, and in both cases, the network provides one IP address per pod - as is standard for Kubernetes.

### CNI-Genie from Huawei

[CNI-Genie](https://github.com/Huawei-PaaS/CNI-Genie) is an open source software that enables Kubernetes to [simultanously have access to different implementations](https://github.com/Huawei-PaaS/CNI-Genie/blob/master/docs/multiple-cni-plugins/README.md#what-cni-genie-feature-1-multiple-cni-plugins-enables) of [Kubernetes network model](https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/concepts/cluster-administration/networking.md#kubernetes-model) in runtime. This includes any implementation that runs as a [CNI plugin](https://github.com/containernetworking/cni#3rd-party-plugins), such as [Flannel](https://github.com/coreos/flannel#flannel), [Calico](http://docs.projectcalico.org/), [Romana](http://romana.io), [Weave-net](https://www.weave.works/products/weave-net/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenopis
Copy link
Contributor

@thockin You have a moment to take a quick look at this?

@kshafiee
Copy link
Contributor Author

kshafiee commented Jun 1, 2017

@thockin since it was just mentioned in the SIG meeting that today is the code freeze, do you think this PR could possibly be considered for 1.7 release?

@thockin
Copy link
Member

thockin commented Jun 4, 2017

Docs changes are governed differently from code changes, and this is not release specific.

@@ -223,6 +223,12 @@ Weave Net runs as a [CNI plug-in](https://www.weave.works/docs/net/latest/cni-pl
or stand-alone. In either version, it doesn't require any configuration or extra code
to run, and in both cases, the network provides one IP address per pod - as is standard for Kubernetes.

### CNI-Genie from Huawei

[CNI-Genie](https://github.com/Huawei-PaaS/CNI-Genie) is an open source software that enables Kubernetes to [simultanously have access to different implementations](https://github.com/Huawei-PaaS/CNI-Genie/blob/master/docs/multiple-cni-plugins/README.md#what-cni-genie-feature-1-multiple-cni-plugins-enables) of the [Kubernetes network model](https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/concepts/cluster-administration/networking.md#kubernetes-model) in runtime. This includes any implementation that runs as a [CNI plugin](https://github.com/containernetworking/cni#3rd-party-plugins), such as [Flannel](https://github.com/coreos/flannel#flannel), [Calico](http://docs.projectcalico.org/), [Romana](http://romana.io), [Weave-net](https://www.weave.works/products/weave-net/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/an open source software/a CNI plugin/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thockin comment addressed!

@thockin
Copy link
Member

thockin commented Jun 5, 2017

Back to you @chenopis

@chenopis chenopis merged commit 8d20ed8 into kubernetes:master Jun 5, 2017
chenopis added a commit that referenced this pull request Jun 5, 2017
…hub.io into release-1.7

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Add TCP socket health check example (#3977)
  Update networking.md (#3950)
  [authorization] fix invalid href for webhook
chenopis added a commit that referenced this pull request Jun 5, 2017
…hub.io into release-1.6

* 'master' of https://github.com/kubernetes/kubernetes.github.io:
  Add TCP socket health check example (#3977)
  Update networking.md (#3950)
  [authorization] fix invalid href for webhook
chenopis added a commit to iphutch/kubernetes.github.io that referenced this pull request Jun 26, 2017
…hub.io

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (859 commits)
  fixed the line giving the template for creating configmap, should include the word configmap as part of the creation process.
  Fixes issue kubernetes#3939
  Add CRI runtime support
  Updaated install-kubeadm.md, removed redundant kubectl installation (kubernetes#4006)
  Add Chocolatey Package Manager for Windows (kubernetes#4000)
  Make issue title automatically a link
  Update directions for macOS bash completion
  Add TCP socket health check example (kubernetes#3977)
  Update networking.md (kubernetes#3950)
  [authorization] fix invalid href for webhook
  Remove self-referential link
  Add fibre channel volume explanation (kubernetes#3967)
  Improve RBAC doc (kubernetes#3951)
  Clarify CNI acronym
  Fix 404 to kubectl install link
  install-kubectl.md: Fix Windows texts, link to latest macOS binaries
  Create Installing kubeadm topic. (kubernetes#3709)
  Fix example in the "Adding ConfigMap data to a Volume" section
  Update ExternalName example
  Completes PR kubernetes#3325
  ...

# Conflicts:
#	_data/tasks.yml
#	docs/tasks/administer-cluster/namespaces-walkthrough.md
#	docs/tasks/administer-cluster/namespaces.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants