-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fibre channel volume explanation #3967
Conversation
docs/concepts/storage/volumes.md
Outdated
@@ -74,6 +74,7 @@ Kubernetes supports several types of Volumes: | |||
* `awsElasticBlockStore` | |||
* `nfs` | |||
* `iscsi` | |||
* `fc(fibre_channel)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underscore is not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
docs/concepts/storage/volumes.md
Outdated
targetWWNs in your volume configuration. If multiple WWNs are specified, | ||
targetWWNs expects that those WWNs form multipath connection. | ||
|
||
__Important: You must have your own FC Storage setup running with the volume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FC SAN Zone manager must allocate and mask those LUNs to the target WWNs so Kubernetes hosts can access them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
/assign |
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 small typo nits.
docs/concepts/storage/volumes.md
Outdated
@@ -74,6 +74,7 @@ Kubernetes supports several types of Volumes: | |||
* `awsElasticBlockStore` | |||
* `nfs` | |||
* `iscsi` | |||
* `fc(fibre channel)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space between 'fc' and '(fibre channel)'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review. done
docs/concepts/storage/volumes.md
Outdated
targetWWNs expects that those WWNs form multipath connection. | ||
|
||
__Important: You must configure FC SAN Zoning to allocate and mask those | ||
LUNs(volumues) to the target WWNs beforehand so that Kubernetes hosts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add space after "LUNs"
- "volumues" => "volumes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
This patch adds explanation of fibre channel volume including usage of multiple WWNs. Fix kubernetes#33602
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed a couple earlier.
docs/concepts/storage/volumes.md
Outdated
@@ -320,6 +321,19 @@ simultaneous writers allowed. | |||
|
|||
See the [iSCSI example](https://github.com/kubernetes/kubernetes/tree/{{page.githubbranch}}/examples/volumes/iscsi) for more details. | |||
|
|||
### fc(fibre channel) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a space between "fc" and "(fibre channel)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed too... got it.
docs/concepts/storage/volumes.md
Outdated
@@ -320,6 +321,19 @@ simultaneous writers allowed. | |||
|
|||
See the [iSCSI example](https://github.com/kubernetes/kubernetes/tree/{{page.githubbranch}}/examples/volumes/iscsi) for more details. | |||
|
|||
### fc(fibre channel) | |||
|
|||
A `fc` volume allows an existing fibre channel volume to be mounted into your pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A" => "An"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An fc
? What is this rule?
A glusterfs
A flocker
An rbd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rule is to use "an" for words that sound like they start with a vowel even if the first letter is a consonant. In this case, since 'fc' is an acronym, it would be pronounced EFF-CEE. Consequently, the leading sound is a vowel, so "an" should be used.
Admittedly, the rules of English are confusing. =) |
Now that rule is make sense to me :) Thanks. |
…hub.io into release-1.7 * 'master' of https://github.com/kubernetes/kubernetes.github.io: Remove self-referential link Add fibre channel volume explanation (#3967)
…hub.io * 'master' of https://github.com/kubernetes/kubernetes.github.io: (859 commits) fixed the line giving the template for creating configmap, should include the word configmap as part of the creation process. Fixes issue kubernetes#3939 Add CRI runtime support Updaated install-kubeadm.md, removed redundant kubectl installation (kubernetes#4006) Add Chocolatey Package Manager for Windows (kubernetes#4000) Make issue title automatically a link Update directions for macOS bash completion Add TCP socket health check example (kubernetes#3977) Update networking.md (kubernetes#3950) [authorization] fix invalid href for webhook Remove self-referential link Add fibre channel volume explanation (kubernetes#3967) Improve RBAC doc (kubernetes#3951) Clarify CNI acronym Fix 404 to kubectl install link install-kubectl.md: Fix Windows texts, link to latest macOS binaries Create Installing kubeadm topic. (kubernetes#3709) Fix example in the "Adding ConfigMap data to a Volume" section Update ExternalName example Completes PR kubernetes#3325 ... # Conflicts: # _data/tasks.yml # docs/tasks/administer-cluster/namespaces-walkthrough.md # docs/tasks/administer-cluster/namespaces.md
This patch adds explanation of fibre channel volume including usage of multiple WWNs.
Fix #33602
kubernetes/kubernetes#33602
This change is