Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove details for out-of-tree Service integration (TKE) #38550

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

sftim
Copy link
Contributor

@sftim sftim commented Dec 19, 2022

Tencent Kubernetes Engine does not have an in-tree or in-project integration with the Service API, so we wouldn't document it.

This PR removes the third party documentation there. See issue #20232.

(in case anyone's wondering, the AWS integration is done using code that is part of the Kubernetes project)

These changes are also included within PR #30817

Tencent Kubernetes Engine does not have an in-tree or in-project
integration with the Service API, so we wouldn't document it.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2022
@netlify
Copy link

netlify bot commented Dec 19, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 89d8ac3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63a02c15a9e25d0008a534e1
😎 Deploy Preview https://deploy-preview-38550--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mengjiao-liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4697cc4b47738773c01b5bfa135d4df7968f4f0d

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sftim for this!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9111f32 into kubernetes:main Dec 21, 2022
@sftim sftim deleted the 20221219_drop_tke_from_service branch December 21, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants