Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog for non-graceful node shutdown #41914

Merged
merged 1 commit into from Aug 3, 2023

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Jul 6, 2023

Placeholder blog PR for kubernetes/enhancements#2268

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jul 6, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 6, 2023
@xing-yang xing-yang changed the title WIP: Placeholder PR - Add blog for non-graceful node shutdown WIP: Add blog for non-graceful node shutdown Jul 6, 2023
@netlify
Copy link

netlify bot commented Jul 6, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8be30c6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64cb092fd6971b000871f044
😎 Deploy Preview https://deploy-preview-41914--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 31, 2023
@xing-yang xing-yang changed the title WIP: Add blog for non-graceful node shutdown Add blog for non-graceful node shutdown Jul 31, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2023
@xing-yang
Copy link
Contributor Author

/assign @gnufied @msau42

Copy link
Contributor

@YuikoTakada YuikoTakada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. I wrote some comments.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2023
@xing-yang
Copy link
Contributor Author

Comments are addressed. Thanks.

@tengqm
Copy link
Contributor

tengqm commented Aug 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@YuikoTakada
Copy link
Contributor

Thank you for updating. Looks good to me.

@gnufied
Copy link
Member

gnufied commented Aug 3, 2023

lgtm from feature documentation perspective.

/gtm

@gnufied
Copy link
Member

gnufied commented Aug 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a2908aa47f66b9f7ea44ed586d4dc04470baf5e2

@k8s-ci-robot k8s-ci-robot merged commit 7e2c916 into kubernetes:main Aug 3, 2023
7 checks passed
@sftim
Copy link
Contributor

sftim commented Aug 8, 2023

@tengqm - this didn't actually have a date assigned (by release comms) and needs a fix. We'll do that in a follow up PR.

@sftim
Copy link
Contributor

sftim commented Aug 15, 2023

Also see #42546 (which will publish the article).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

None yet

8 participants