Feature Gate VolumeSubpathEnvExpansion #8835

kevtaylor · 2018-05-31T07:54:13Z

Adds the VolumeSubpathEnvExpansion alpha feature to support environment variable expansion

k8sio-netlify-preview-bot · 2018-05-31T07:54:16Z

Deploy preview for kubernetes-io-vnext-staging processing.

Built with commit d234510

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5b1b919fe39e7c4f52cb8932

kevtaylor · 2018-05-31T07:54:21Z

/hold

kevtaylor · 2018-05-31T07:54:31Z

/milestone 1.11

kevtaylor · 2018-05-31T07:57:26Z

@jberkus I hope this is what you had in mind. If not please advise accordingly
/cc @msau42

tengqm · 2018-05-31T08:02:50Z

@kevtaylor Please don't do this. The generated docs for release-1.11 will by updated by the branch maintainer when needed. We do welcome any kind of documentation about this feature gate though. As a user/operator, some explanation about the feature gate would be very useful.

kevtaylor · 2018-05-31T08:08:18Z

@tengqm Please can you clarify that - you want me to remove this change because it is auto-generated?
And then, where should I put some explanation docs? - Can you point me to an example?

kevtaylor · 2018-05-31T08:24:07Z

@tengqm Okay, I found a link to how to do this. I'll put something in

kevtaylor · 2018-05-31T09:03:20Z

@tengqm Please can you re-review and see if this is now okay?

kevtaylor · 2018-05-31T09:27:24Z

/milestone v1.11

Looks like I don't have authority to do that :-(

tengqm · 2018-05-31T10:11:39Z

content/en/docs/tasks/configure-pod-container/subpath-env-expansion.md

+---
+
+{{% capture overview %}}
+This page shows how to configure a subpath and allow expansion of a variable host path


End a sentence with a period please, :)

tengqm · 2018-05-31T10:17:35Z

content/en/docs/tasks/configure-pod-container/subpath-env-expansion.md

+
+{{% capture prerequisites %}}
+
+* The feature gate VolumeSubpathEnvExpansion must be enabled


Please also update content/en/docs/reference/command-line-tools-reference/feature-gates.md

tengqm · 2018-05-31T10:18:21Z

content/en/docs/tasks/configure-pod-container/subpath-env-expansion.md

+## Using kubectl to create a pod definition
+
+
+* The host path can be mounted into the pod and written to as any other volume


Always spell Pod as 'Pod', first character capitalized.

Instead of saying 'host path', you may want to instead using the field names in the yaml file.
BTW, this feature is only applicable to hostpath volumes?

tengqm · 2018-05-31T10:18:58Z

content/en/docs/tasks/configure-pod-container/subpath-env-expansion.md

+
+
+* The host path can be mounted into the pod and written to as any other volume
+* The subpath can contain unique elements from the downstream api


Are you referring to 'Downward API'?

tengqm · 2018-05-31T10:22:21Z

content/en/docs/tasks/configure-pod-container/subpath-env-expansion.md

+
+* The host path can be mounted into the pod and written to as any other volume
+* The subpath can contain unique elements from the downstream api
+* The host path sub folders will be expanded and the folders created on the host


The "host path sub folders" is confusing, please try rephrase it.

kevtaylor · 2018-05-31T11:36:14Z

@tengqm Thanks for the review. Hopefully that addresses your points.

tengqm

/lgtm

msau42 · 2018-05-31T22:11:18Z

content/en/docs/tasks/configure-pod-container/subpath-env-expansion.md

@@ -0,0 +1,69 @@
+---
+title: Config the subpath using environment variables


Would this be better suited as an addition to the current subpath documentation here:
https://kubernetes.io/docs/concepts/storage/volumes/#using-subpath

kevtaylor · 2018-06-01T12:14:08Z

@msau42 How does that look to you now?

msau42 · 2018-06-01T23:31:40Z

content/en/docs/concepts/storage/volumes.md

@@ -985,6 +985,59 @@ spec:
        claimName: my-lamp-site-data
 ```

+## Using subPath with expanded environment variables


Make this 3rd level header under subpath

And add this alpha feature tag:

{{< feature-state for_k8s_version="v1.11" state="alpha" >}}

msau42 · 2018-06-01T23:33:07Z

content/en/docs/concepts/storage/volumes.md

@@ -985,6 +985,59 @@ spec:
        claimName: my-lamp-site-data
 ```

+## Using subPath with expanded environment variables
+
+The following Pod definition shows how to configure unique subpaths and allow expansion of a variable host path.


I think we should avoid using "host path" to not confuse it with hostPath volumes. Maybe something like this?

"subPath directory names can also be constructed from Downward API environment variables. Here is an example of a Pod that uses subPath to create a logs directory with the pod name."

msau42 · 2018-06-01T23:34:44Z

content/en/docs/concepts/storage/volumes.md

+
+The following Pod definition shows how to configure unique subpaths and allow expansion of a variable host path.
+
+* The feature gate VolumeSubpathEnvExpansion must be enabled


Put this feature gate sentence under the alpha feature tag.

msau42 · 2018-06-01T23:35:26Z

content/en/docs/concepts/storage/volumes.md

+The following Pod definition shows how to configure unique subpaths and allow expansion of a variable host path.
+
+* The feature gate VolumeSubpathEnvExpansion must be enabled
+* The `mountPath` can be mounted into the Pod and written to as any other volume with optional `subPath`


I don't think think we need these 4 points

msau42 · 2018-06-01T23:36:04Z

content/en/docs/concepts/storage/volumes.md

+    volumeMounts:
+    - name: workdir1
+      mountPath: /logscontainer
+      subPath: $(POD_NAME)/$(POD_NAME)


Why does the directory need pod name twice?

msau42 · 2018-06-01T23:38:01Z

content/en/docs/concepts/storage/volumes.md

+          apiVersion: v1
+          fieldPath: metadata.name
+    image: busybox
+    command: [ "sh", "-c", "while [ true ]; do echo 'Hello'; sleep 10; done | tee -a /testcontainer/$(POD_NAME)/$(POD_NAME)/hello.txt" ]


It would make more sense if these example wrote to /logs

msau42 · 2018-06-01T23:38:26Z

content/en/docs/concepts/storage/volumes.md

+    command: [ "sh", "-c", "while [ true ]; do echo 'Hello'; sleep 10; done | tee -a /testcontainer/$(POD_NAME)/$(POD_NAME)/hello.txt" ]
+    volumeMounts:
+    - name: workdir1
+      mountPath: /logscontainer


change this to /logs for simplicity

msau42 · 2018-06-01T23:38:37Z

content/en/docs/concepts/storage/volumes.md

+    - name: workdir1
+      mountPath: /logscontainer
+      subPath: $(POD_NAME)/$(POD_NAME)
+    - name: workdir2


Is this 2nd mount needed?

kevtaylor · 2018-06-02T14:05:01Z

@msau42 Addressed your comments. I trimmed down the sample pod definition - I used this as my example test file for a variety of use-cases but was not necessary for the purposes of this documentation. I think it looks much tidier now. See what you think. Thanks again.

tengqm · 2018-06-04T02:08:56Z

/lgtm

kevtaylor · 2018-06-07T07:55:35Z

@msau42 It looks like some nice 'tidy' up has been done by yourself and @mistyhacks after our slack chat. If there are any other snags/clarifications that need addressing, please let me know.

msau42 · 2018-06-07T16:02:08Z

@kevtaylor I had some suggestions on the new revisions. Also I think the example could be less confusing if we used different paths for the mountPath and hostpath

kevtaylor · 2018-06-08T07:50:03Z

/hold cancel

kevtaylor · 2018-06-08T07:53:55Z

@msau42 Addressed the review comments and lifted the placeholder/hold status and squashed the commits. Please give it your final (hopefully) scrutiny.
/cc @mistyhacks

msau42 · 2018-06-08T17:23:03Z

content/en/docs/concepts/storage/volumes.md

+
+
+
+You can use expanded environment variables in a subPath value. `subPath` directory names can also


I would remove the first sentence since it is covered in the 2nd sentence.

Do you want to remove the first sentence?

msau42 · 2018-06-08T17:26:16Z

content/en/docs/concepts/storage/volumes.md

+be constructed from Downward API environment variables. Before you use this feature, you must enable
+the `VolumeSubpathEnvExpansion`feature gate.
+
+In this example, a Pod uses `subPath` to create a directory within `/logs/pod1/`, using


How does this sound?

In this example, a Pod uses `subPath` to create a directory `pod1` within the hostPath volume `/var/log/pods`, using the pod name from the Downward API. The host directory "/var/log/pods/pod1" is mounted at `/logs` in the container.

@msau42 Addressed comment. Seems quite to the point now.

msau42 · 2018-06-08T20:00:39Z

content/en/docs/concepts/storage/volumes.md

+be constructed from Downward API environment variables. Before you use this feature, you must enable
+the `VolumeSubpathEnvExpansion`feature gate.
+
+In this example, a Pod uses `subPath` to create a directory `pod1` within the hostPath volume `/var/log/pods`, using the pod name from the Downward API.  The host directory "/var/log/pods/pod1" is mounted at `/logs` in the container.


use backtick for /var/log/pods/pod1

msau42 · 2018-06-08T20:01:07Z

content/en/docs/concepts/storage/volumes.md

+
+
+
+You can use expanded environment variables in a subPath value. `subPath` directory names can also


Do you want to remove the first sentence?

kevtaylor · 2018-06-08T20:30:24Z

@msau42 Okay - yes, removed the sentence as it seems superfluous. Have a look now. We'll get there :-)

msau42 · 2018-06-08T23:57:42Z

content/en/docs/concepts/storage/volumes.md

+{{< feature-state for_k8s_version="v1.11" state="alpha" >}}
+
+
+Before you use this feature, you must enable the `VolumeSubpathEnvExpansion`feature gate.


Ah sorry, there were actually 2 sentences, and I was only talking about removing the first. Could you add this back?

`subPath` directory names can also be constructed from Downward API environment variables.

@msau42 Put back the descriptive sentence

msau42 · 2018-06-11T17:26:29Z

/lgtm
Thanks!

kevtaylor · 2018-06-11T18:21:09Z

/assign @mistyhacks

mdlinville · 2018-06-12T22:04:25Z

This looks great! Thanks to both for your hard work on this.

/approve

k8s-ci-robot · 2018-06-12T22:04:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mistyhacks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Seperate priority and preemption (#8144) * Doc about PID pressure condition. (#8211) * Doc about PID pressure condition. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * "so" -> "too" * Update version selector for 1.11 * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * CRIContainerLogRotation is Beta in 1.11 (#8665) * Seperate priority and preemption (#8144) * CRIContainerLogRotation is Beta in 1.11 xref: kubernetes/kubernetes#64046 * Bring StorageObjectInUseProtection feature to GA (#8159) * StorageObjectInUseProtection is GA (#8291) * Feature gate: StorageObjectInUseProtection is GA Update feature gate reference for 1.11 * Trivial commit to re-trigger Netlify * Bring StorageObjectInUseProtection feature to GA StorageObjectInUseProtection is Beta in K8s 1.10. It's brought to GA in K8s 1.11. * Fixed typo and added feature state tags. * Remove KUBE_API_VERSIONS doc (#8292) The support to the KUBER_API_VERSIONS environment variable is completely dropped (no deprecation). This PR removes the related doc in release-1.11. xref: kubernetes/kubernetes#63165 * Remove InitialResources from admission controllers (#8293) The feature (was experimental) is dropped in 1.11. xref: kubernetes/kubernetes#58784 * Remove docs related to in-tree support to GPU (#8294) * Remove docs related to in-tree support to GPU The in-tree support to GPU is completely removed in release 1.11. This PR removes the related docs in release-1.11 branch. xref: kubernetes/kubernetes#61498 * Update content updated by PR to Hugo syntax Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Update the doc about extra volume in kubeadm config (#8453) Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com> * Update CRD Subresources for 1.11 (#8519) * coredns: update notes in administer-cluster/coredns.md (#8697) CoreDNS is installed by default in 1.11. Add notes on how to install kube-dns instead. Update notes about CoreDNS->CoreDNS upgrades as in 1.11 the Corefile is retained. Add example on upgrading from kube-dns to CoreDNS. * kubeadm-alpha: CoreDNS related changes (#8727) Update note about CoreDNS feature gate. This change also updates a tab as a kubeadm sub-command will change. It looks for a new generated file: generated/kubeadm_alpha_phase_addon_coredns.md instead of: generated/kubeadm_alpha_phase_addon_kube-dns.md * Update cloud controller manager docs to beta 1.11 (#8756) * Update cloud controller manager docs to beta 1.11 * Use Hugo shortcode for feature state * kubeadm-upgrade: include new command `kubeadm upgrade diff` (#8617) Also: - Include note that this was added in 1.11. - Modify the note about upgrade guidance. * independent: update CoreDNS mentions for kubeadm (#8753) Give CoreDNS instead of kube-dns examples in: - docs/setup/independent/create-cluster-kubeadm.md - docs/setup/independent/troubleshooting-kubeadm.md * update 1.11 --server-print info (#8870) * update 1.11 --server-print info * Copyedit * Mark ExpandPersistentVolumes feature to beta (#8778) * Update version selector for 1.11 * Mark ExpandPersistentVolumes Beta xref: kubernetes/kubernetes#64288 * fix shortcode, add placeholder files to fix deploy failures (#8874) * declare ipvs ga (#8850) * kubeadm: update info about CoreDNS in kubeadm-init.md (#8728) Add info to install kube-dns instead of CoreDNS, as CoreDNS is the default DNS server in 1.11. Add notes that kubeadm config images can be used to list and pull the required images in 1.11. * kubeadm: update implementation-details.md about CoreDNS (#8829) - Replace examples from kube-dns to CoreDNS - Add notes about the CoreDNS feature gate status in 1.11 - Add note that the service name for CoreDNS is also called `kube-dns` * Update block device support for 1.11 (#8895) * Update block device support for 1.11 * Copyedits * Fix typo 'fiber channel' (#8957) Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * kubeadm-upgrade: add the 'node [config]' sub-command (#8960) - Add includes for the generated pages - Include placeholder generated pages * kubeadm-init: update the example for the MasterConfiguration (#8958) - include godocs link for MasterConfiguration - include example MasterConfiguration - add note that `kubeadm config print-default` can be used * kubeadm-config: include new commands (#8862) Add notes and includes for these new commands in 1.11: - kubeadm config print-default - kubeadm config migrate - kubeadm config images list - kubeadm config images pull Include placeholder generated files for the above. * administer-cluster/coredns: include more changes (#8985) It was requested that for this page a couple of methods should be outlined: - manual installation for CoreDNS explained at the Kubernetes section of the GitHub project for CoreDNS - installation and upgrade via kubeadm Make the above changes and also add a section "About CoreDNS". This commit also lowercases a section title. * Update CRD subresources doc for 1.11 (#8918) * Add docs for volume expansion and online resizing (#8896) * Add docs for volume expansion going beta * Copyedit * Address feedback * Update exec plugin docs with TLS credentials (#8826) * Update exec plugin docs with TLS credentials kubernetes/kubernetes#61803 implements TLS client credential support for 1.11. * Copyedit * More copyedits for clarification * Additional copyedit * Change token->credential * NodeRestriction admission prevents kubelet taint removal (#8911) * dns-custom-namerserver: break down the page into mutliple sections (#8900) * dns-custom-namerserver: break down the page into mutliple sections This page is currently about kube-dns and is a bit outdated. Introduce the heading `# Customizing kube-dns`. Introduce a separate section about CoreDNS. * Copyedits, fix headings for customizing DNS Hey Lubomir, I coypedited pretty heavily because this workflow is so much easier for docs and because I'm trying to help improve everything touching kubeadm as much as possible. But there's one outstanding issue wrt headings and intro content: you can't add a heading 1 to a topic to do what you wanted to do. The page title in the front matter is rendered as a heading 1 and everything else has to start at heading 2. (We still need to doc this better in the docs contributing content, I know.) Instead, I think we need to rewrite the top-of-page intro content to explain better the relationship between kube-dns and CoreDNS. I'm happy to write something, but I thought I'd push this commit first so you can see what I'm doing. Hope it's all clear -- ping here or on Slack with any questions ~ Jennifer * Interim fix for talking about CoreDNS * Fix CoreDNS details * PSP readOnly hostPath (#8898) * Add documentation for crictl (#8880) * Add documentation for crictl * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Final copyedit * VolumeSubpathEnvExpansion alpha feature (#8835) * Note that Heapster is deprecated (#8827) * Note that Heapster is deprecated This notes that Heapster is deprecated, and migrates the relevant docs to talk about metrics-server or other solutions by default. * Copyedits and improvements Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * fix shortcode to troubleshoot deploy (#9057) * update dynamic kubelet config docs for v1.11 (#8766) * update dynamic kubelet config docs for v1.11 * Substantial copyedit * Address feedback * Reference doc for kubeadm (release-1.11) (#9044) * Reference doc for kubeadm (release-1.11) * fix shortcode to troubleshoot deploy (#9057) * Reference doc for kube-components (release-1.11) (#9045) * Reference doc for kube-components (release-1.11) * Update cloud-controller-manager.md * fix shortcode to troubleshoot deploy (#9057) * Documentation on lowercasing kubeadm init apiserver SANs (#9059) * Documentation on lowercasing kubeadm init apiserver SANs * fix shortcode to troubleshoot deploy (#9057) * Clarification in dynamic Kubelet config doc (#9061) * Promote sysctls to Beta (#8804) * Promote sysctls to Beta * Copyedits Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Review comments * Address feedback * More feedback * kubectl reference docs for 1.11 (#9080) * Update Kubernetes API 1.11 ref docs (#8977) * Update v1alpha1 to v1beta1. * Adjust left nav for 1.11 ref docs. * Trim list of old ref docs. * Update Federation API ref docs for 1.11. (#9064) * Update Federation API ref docs for 1.11. * Add titles. * Update definitions.html * CRD versioning Public Documentation (#8834) * CRD versioning Public Documentation * Copyedit Signed-off-by: Misty Stanley-Jones <mistyhacks@google.com> * Address feedback * More rewrites * Address feedback * Update main CRD page in light of versioning * Reorg CRD docs * Further reorg * Tweak title * CSI documentation update for raw block volume support (#8927) * CSI documetation update for raw block volume support * minor edits for "CSI raw block volume support" Some small grammar and style nits. * minor CSIBlockVolume edits * Update kubectl component ref page for 1.11. (#9094) * Update kubectl component ref page for 1.11. * Add title. Replace stevepe with username. * crd versioning doc: fix nits (#9142) * Update `DynamicKubeletConfig` feature to beta (#9110) xref: kubernetes/kubernetes#64275 * Documentation for dynamic volume limits based on node type (#8871) * add cos for storage limits * Update docs specific for aws and gce * fix some minor things * Update storage-limits.md * Add k8s version to feature-state shortcode * The Doc update for ScheduleDaemonSetPods (#8842) Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> * Update docs related to PersistentVolumeLabel admission control (#9109) The said admission controller is disabled by default in 1.11 (kubernetes/kubernetes#64326) and scheduled to be removed in future release. * client exec auth: updates for 1.11 (#9154) * Updates HA kubeadm docs (#9066) * Updates HA kubeadm docs Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * kubeadm HA - Add stacked control plane steps * ssh instructions and some typos in the bash scripts Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * Fix typos and copypasta errors * Fix rebase issues * Integrate more changes Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * copyedits, layout and formatting fixes * final copyedits * Adds a sanity check for load balancer connection Signed-off-by: Chuck Ha <ha.chuck@gmail.com> * formatting fixes, copyedits * fix typos, formatting * Document the Pod Ready++ feature (#9180) Closes: #9107 Xref: kubernetes/kubernetes#64057 * Mention 'KubeletPluginsWatcher' feature (#9177) * Mention 'KubeletPluginsWatcher' feature This feature is more developers oriented than users oriented, so simply mention it in the feature gate should be fine. In future, when the design doc is migrated from Google doc to the kubernetes/community repo, we can add links to it for users who want to dig deeper. Closes: #9108 Xref: kubernetes/kubernetes#63328, kubernetes/kubernetes#64605 * Copyedit * Amend dynamic volume list docs (#9181) The dynamic volume list feature has been documented but the feature gate related was not there yet. Closes: #9105 * Document for service account projection (#9182) This adds docs for the service account projection feature. Xref: kubernetes/kubernetes#63819, kubernetes/community#1973 Closes: #9102 * Update pod priority and preemption user docs (#9172) * Update pod priority and preemption user docs * Copyedit * Documentation on setting node name with Kubeadm (#8925) * Documentation on setting node name with Kubeadm * copyedit * Add kubeadm upgrade docs for 1.11 (#9089) * Add kubeadm upgrade docs for 1.11 * Initial docs review feedback * Add 1-11 to outline * Fix formatting on tab blocks * Move file to correct location * Add `kubeadm upgrade node config` step * Overzealous ediffing * copyedit, fix lists and headings * clarify --force flag for fixing bad state * Get TOML ready for 1.11 release * Blog post for 1.11 release (#9254) * Blog post for 1.11 release * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md * Update 2018-06-26-kubernetes-1.11-release-announcement.md

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 31, 2018

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 31, 2018

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2018

k8s-ci-robot requested review from tengqm and zhangxiaoyu-zidif May 31, 2018 07:54

k8s-ci-robot requested a review from msau42 May 31, 2018 07:57

kevtaylor force-pushed the feature/VolumeSubpathEnvExpansion branch from 68ab684 to ebad427 Compare May 31, 2018 08:59

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2018

tengqm reviewed May 31, 2018

View reviewed changes

Bradamant3 added this to the 1.11 milestone May 31, 2018

k8s-ci-robot assigned tengqm May 31, 2018

tengqm approved these changes May 31, 2018

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2018

msau42 reviewed May 31, 2018

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2018

msau42 reviewed Jun 1, 2018

View reviewed changes

kevtaylor force-pushed the feature/VolumeSubpathEnvExpansion branch from 85dde05 to b32b33f Compare June 8, 2018 07:46

kevtaylor changed the title ~~[Placeholder] Feature Gate VolumeSubpathEnvExpansion~~ Feature Gate VolumeSubpathEnvExpansion Jun 8, 2018

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2018

k8s-ci-robot requested a review from mdlinville June 8, 2018 07:53

msau42 reviewed Jun 8, 2018

View reviewed changes

kevtaylor force-pushed the feature/VolumeSubpathEnvExpansion branch from b32b33f to 2788dd8 Compare June 8, 2018 18:59

msau42 reviewed Jun 8, 2018

View reviewed changes

kevtaylor force-pushed the feature/VolumeSubpathEnvExpansion branch from 2788dd8 to b5f3765 Compare June 8, 2018 20:28

msau42 reviewed Jun 8, 2018

View reviewed changes

VolumeSubpathEnvExpansion alpha feature

d234510

kevtaylor force-pushed the feature/VolumeSubpathEnvExpansion branch from b5f3765 to d234510 Compare June 9, 2018 08:36

kevtaylor unassigned tengqm Jun 9, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018

k8s-ci-robot assigned mdlinville Jun 11, 2018

zacharysarah added the Docs Review: Open Issues label Jun 11, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2018

k8s-ci-robot merged commit 789f45a into kubernetes:release-1.11 Jun 12, 2018

mdlinville pushed a commit that referenced this pull request Jun 20, 2018

VolumeSubpathEnvExpansion alpha feature (#8835)

c1adc37

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

VolumeSubpathEnvExpansion alpha feature (#8835)

47eff43

mdlinville pushed a commit that referenced this pull request Jun 27, 2018

VolumeSubpathEnvExpansion alpha feature (#8835)

4d7c685


		{{% capture prerequisites %}}

		* The feature gate VolumeSubpathEnvExpansion must be enabled

		## Using kubectl to create a pod definition


		* The host path can be mounted into the pod and written to as any other volume



		* The host path can be mounted into the pod and written to as any other volume
		* The subpath can contain unique elements from the downstream api

		@@ -0,0 +1,69 @@
		---
		title: Config the subpath using environment variables


		The following Pod definition shows how to configure unique subpaths and allow expansion of a variable host path.

		* The feature gate VolumeSubpathEnvExpansion must be enabled




		You can use expanded environment variables in a subPath value. `subPath` directory names can also

		{{< feature-state for_k8s_version="v1.11" state="alpha" >}}


		Before you use this feature, you must enable the `VolumeSubpathEnvExpansion`feature gate.

Feature Gate VolumeSubpathEnvExpansion #8835

Feature Gate VolumeSubpathEnvExpansion #8835

Conversation

kevtaylor commented May 31, 2018 • edited Loading

k8sio-netlify-preview-bot commented May 31, 2018 • edited Loading

kevtaylor commented May 31, 2018

kevtaylor commented May 31, 2018

kevtaylor commented May 31, 2018

tengqm commented May 31, 2018

kevtaylor commented May 31, 2018

kevtaylor commented May 31, 2018

kevtaylor commented May 31, 2018

kevtaylor commented May 31, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevtaylor commented May 31, 2018

tengqm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevtaylor commented Jun 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevtaylor commented Jun 2, 2018

tengqm commented Jun 4, 2018

kevtaylor commented Jun 7, 2018

msau42 commented Jun 7, 2018

kevtaylor commented Jun 8, 2018

kevtaylor commented Jun 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevtaylor commented Jun 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Jun 11, 2018

kevtaylor commented Jun 11, 2018

mdlinville commented Jun 12, 2018

k8s-ci-robot commented Jun 12, 2018

kevtaylor commented May 31, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented May 31, 2018 •

edited

Loading

kevtaylor commented May 31, 2018 •

edited

Loading