Added tier label

[amirmalka]

User description

Part of : https://github.com/kubescape/helm-charts/pull/408/files

---

Type

enhancement

---

Description

• Introduced a new metadata key TierMetadataKey to categorize resources by tier.
• Added a constant CoreTier to define core tier resources, enhancing the metadata categorization.

---

Changes walkthrough

	Relevant files
Enhancement	keys.go Introduce Tier Metadata and Core Tier Constant                      instanceidhandler/v1/helpers/keys.go Added a new constant TierMetadataKey for tier metadata. Introduced a new constant CoreTier representing the core tier value. +6/-0

---

✨ PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-free]

PR Description updated to latest commit (4b1bdda)

[codiumai-pr-agent-free]

PR Review

⏱️ Estimated effort to review [1-5]	1, because the changes are straightforward and involve the addition of constants for metadata categorization. The PR is small, with clear enhancements, making it easy to review.
🧪 Relevant tests	No
🔍 Possible issues	No
🔒 Security concerns	No

---

✨ Review tool usage guide:

---

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: [pr_reviewer] # /review # extra_instructions=""" In the 'possible issues' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

How to enable\disable automation When you first install PR-Agent app, the default mode for the review tool is: pr_commands = ["/review", ...] meaning the review tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations

Auto-labels The review tool can auto-generate two specific types of labels for a PR: a possible security issue label, that detects possible security issues (enable_review_labels_security flag) a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

Extra sub-tools The review tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: require_score_review, require_soc2_ticket, and more.

Auto-approve PRs By invoking: /review auto_approve The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: [pr_reviewer] enable_auto_approval = true (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag: [pr_reviewer] maximal_review_effort = 5

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

[codiumai-pr-agent-free]

PR Code Suggestions

Category	Suggestions
Maintainability	Group related constants together for better organization. Consider grouping the TierMetadataKey constant with the other metadata keys for better organization and readability. This helps in maintaining a clear structure for metadata keys and their related constants. instanceidhandler/v1/helpers/keys.go [35] +ClusterRoleBindingNameMetadataKey = metadataPrefix + "/clusterrolebinding-name" +ResourceSizeMetadataKey = metadataPrefix + "/resource-size" +CompletionMetadataKey = metadataPrefix + "/completion" TierMetadataKey = metadataPrefix + "/tier"
Enhancement	Introduce a type for Tier values to enhance type safety and clarity. Since the Tier values are being introduced as constants, it might be beneficial to anticipate future expansion and create a type for Tier. This type can then be used to define variables or function parameters that are expected to take these values, enhancing type safety and code clarity. instanceidhandler/v1/helpers/keys.go [71-73] +type Tier string + const ( - CoreTier = "core" + CoreTier Tier = "core" )
	Add more Tier values to cover a broader range of scenarios. Consider adding more Tier values to cover different scenarios or resource classifications that might be needed in the future. This preemptive addition can save time and provide a more comprehensive handling of various tiers from the start. instanceidhandler/v1/helpers/keys.go [71-73] const ( - CoreTier = "core" + CoreTier = "core" + StandardTier = "standard" + PremiumTier = "premium" )
Best practice	Add a comment explaining the purpose of the new TierMetadataKey. For the newly added TierMetadataKey, consider adding a comment that describes its purpose or the values it might hold. This is especially useful for other developers or for future reference, as it provides context on how and where this metadata key is expected to be used. instanceidhandler/v1/helpers/keys.go [35] +// TierMetadataKey is used to label resources with their tier classification, such as "core". TierMetadataKey = metadataPrefix + "/tier"
	Implement a validation function for Tier values to ensure correctness. Given that new constants are being introduced for Tier values, it's a good practice to also consider how these values will be validated. Implementing a validation function ensures that only expected tier values are processed, which can prevent errors or misuse. instanceidhandler/v1/helpers/keys.go [71-73] const ( CoreTier = "core" ) +// IsValidTier checks if the provided tier is a recognized value. +func IsValidTier(tier Tier) bool { + switch tier { + case CoreTier: + return true + default: + return false + } +} +

---

✨ Improve tool usage guide:

---

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:

/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

With a configuration file, use the following template:

[pr_code_suggestions]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the improve tool is: pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] meaning the improve tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically.

Utilizing extra instructions Extra instructions are very important for the improve tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

A note on code suggestions quality While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the custom suggestions 💎 tool With large PRs, best quality will be obtained by using 'improve --extended' mode.

More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the improve usage page for a more comprehensive guide on using this tool.

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success

[github-actions]

Summary:

• License scan: failure
• Credentials scan: failure
• Vulnerabilities scan: failure
• Unit test: success
• Go linting: success