Fix bug for no matches of yalib in one file mapping #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When executing yqlib, if there is an error, it will return, which causes the crash of Kubescape scanning.
To fix it, instead of generating an error and return, I print a warning log to tell users which files are failing to execute yqlib. Therefore, it will only generate a warning for the files, and scanning will not be stopped.
In this case, in the sarif printer, since the files don't have the file mapping, it will return the default location. The worst case will be all the files fail to execute yqlib, but this is really rare.
Examples/Screenshots
./kubescape scan framework allcontrols ./demo-bitnami-charts -f sarif -o test1.sarifRelated issues/PRs:
exectuateYq err: no matches foundwhen rendering Helm chart #1625