fix(panic): Enhanced Support for Diverse Image ID Formats in Hash Extraction #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wertenteil <dwertent@armosec.io>
|
Thanks for fixing it... It's weird that the official method doesn't account for these forms. |
|
Summary:
|
|
@matthyx Where is the common method? |
|
Doesn't exist yet... It would make sense to have one |
|
@matthyx Should we merge this or should we write such a function? Do we know if the Operator needs such a capability? |
|
let's merge it now, worst case we can extract it later... |
matthyx
approved these changes
May 30, 2023
|
Summary:
|
added 3 commits
May 30, 2023 11:48
Signed-off-by: David Wertenteil <dwertent@armosec.io>
…fix-issue-111 Signed-off-by: David Wertenteil <dwertent@armosec.io>
Signed-off-by: David Wertenteil <dwertent@armosec.io>
|
Summary:
|
dwertent
pushed a commit
that referenced
this pull request
Dec 31, 2023
fix(panic): Enhanced Support for Diverse Image ID Formats in Hash Extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Handling of Various Image ID Formats in Hash Extraction
Resolves: #111
Background:
The current implementation of hash extraction from Image IDs assumes a certain pattern and does not account for all variations of Image IDs, specifically formats like:
There are instances where the Image ID doesn't have enough submatches (less than 3) leading to panic as the existing code tries to access an index that does not exist.
Changes:
This PR provides a robust mechanism to extract the SHA256 hash from Image IDs that can handle varying formats. The key changes include:
Adding a check for plain SHA256 hashes: If the Image ID is a plain SHA256 hash, the function will now directly return it as the hash.
Improved Error Handling: An error is now returned when there is an issue with the hash extraction, instead of the function panicking.
Fallback Mechanism: In cases where the Image ID doesn't match the usual pattern, a fallback mechanism has been implemented to parse and extract the hash using a regular expression.
Impact:
This change will make the hash extraction from Image IDs more robust and prevent unexpected panics. It also improves error handling and provides more detailed error messages to help with troubleshooting.