Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for big image scanning #97

Merged
merged 3 commits into from
Apr 17, 2023
Merged

add support for big image scanning #97

merged 3 commits into from
Apr 17, 2023

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Apr 6, 2023

No description provided.

@matthyx
extract NewFromRegistry before moving it to a deadline
5abb0c9 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx matthyx changed the title extract NewFromRegistry before moving it to a deadline add support for big image scanning Apr 6, 2023
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-created.yaml:Environment-Test. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx
go deeper and add size limit checks
96f50f0 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx
fix nil pointer in storing SBOM and CVE
bff9239 
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx matthyx marked this pull request as ready for review April 6, 2023 13:35
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Summary:

  • License scan: failure
  • Credentials scan: success
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@dwertent dwertent merged commit c13930c into main Apr 17, 2023
@matthyx matthyx deleted the ephemeralstorage branch April 17, 2023 12:53
dwertent
dwertent reviewed Apr 18, 2023
View reviewed changes
config/config.go
@@ -11,6 +11,7 @@ type Config struct {
BackendOpenAPI string `mapstructure:"backendOpenAPI"`
ClusterName string `mapstructure:"clusterName"`
EventReceiverRestURL string `mapstructure:"eventReceiverRestURL"`
MaxImageSize int64 `mapstructure:"maxImageSize"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthyx This config object is global for all of the in-cluster components.
The maxImageSize is specific to the kubevuln, so I don't this it should be part of this structure.
I suggest we should have a dedicated config file for such configurations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, can you create a Jira task for it? I'll check when I can split these configs, as it's not the only config that should remain specific to kubevuln.

dwertent pushed a commit that referenced this pull request Dec 31, 2023
Merge pull request #97 from kubescape/ephemeralstorage
87a27a0 
add support for big image scanning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwertent dwertent dwertent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthyx @dwertent