added testcase for skipping update event notification on invalid updateSettings #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Oct 6, 2020
PrasadG193
approved these changes
Oct 7, 2020
|
Hello @A-kanksh-a , Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂 Team BotKube |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
SUMMARY
Added skip update event test case that should be skipped if invalid Fields are provided in UpdateSettings test config.
Fixes test case - Validate that update events are skipped when invalid fields are passed in updateSetting (e.g status.invalid for Pod) #341