Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added testcase for skipping update event notification on invalid updateSettings #403

Merged

Conversation

akankshakumari393
Copy link
Contributor

ISSUE TYPE
  • Bug fix Pull Request
SUMMARY

Added skip update event test case that should be skipped if invalid Fields are provided in UpdateSettings test config.

Fixes test case - Validate that update events are skipped when invalid fields are passed in updateSetting (e.g status.invalid for Pod) #341

@mergify mergify bot merged commit d3c0db0 into kubeshop:develop Oct 7, 2020
@chetanpdeshmukh
Copy link

Hello @A-kanksh-a ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants