Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack): add thread support #423

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

sgandon
Copy link
Contributor

@sgandon sgandon commented Oct 30, 2020

ISSUE TYPE
  • Feature Pull Request
SUMMARY

adding support for botkube to interact in slack threads
I did update the test bash script that would not run on my zsh shell on my mac.

I Also wanted to add some unit tests but the Slack test server does not support thread messages.

Fixes #422

hack/runtests.sh Outdated Show resolved Hide resolved
@PrasadG193
Copy link
Collaborator

This is awesome! Thanks a lot for the PR.

@mergify mergify bot merged commit 0ad0536 into kubeshop:develop Nov 3, 2020
@chetanpdeshmukh
Copy link

Hello @sgandon ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Slack thread for kubectl query
3 participants