Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoyfleet Controller doesn't add finalizers for the CR #1031

Closed
jasmingacic opened this issue Dec 14, 2022 · 0 comments · Fixed by #1045
Closed

Envoyfleet Controller doesn't add finalizers for the CR #1031

jasmingacic opened this issue Dec 14, 2022 · 0 comments · Fixed by #1045
Assignees
Labels

Comments

@jasmingacic
Copy link
Contributor

When reconciling Envoyfleets finalizer is not added:

# kubectl get envoyfleet -nkusk-system   kusk-gateway-envoy-fleet -o yaml
apiVersion: gateway.kusk.io/v1alpha1
kind: EnvoyFleet
metadata:
  creationTimestamp: "2022-12-14T09:32:10Z"
  generation: 1
  name: kusk-gateway-envoy-fleet
  namespace: kusk-system
  resourceVersion: "2443"
  uid: 78d801ca-6603-4a1a-9943-dd8ac6f677c6
spec:
  accesslog:
    format: text
  default: true
  image: docker.io/envoyproxy/envoy:v1.23.1
  service:
    ports:
    - name: http
      port: 80
      protocol: TCP
      targetPort: http
    - name: https
      port: 443
      protocol: TCP
      targetPort: http
    type: LoadBalancer
  size: 1
  tls:
    tlsSecrets: []
status:
  state: Deployed

Other objects like API have it:

# kubectl get api -n kusk-system kusk-gateway-api -o yaml 
apiVersion: gateway.kusk.io/v1alpha1
kind: API
metadata:
  creationTimestamp: "2022-12-14T09:32:10Z"
  finalizers:
  - gateway.kusk.io/apifinalizer
  generation: 1
  labels:
# kubectl get staticroute -n kusk-system kusk-gateway-dashboard -o yaml apiVersion: gateway.kusk.io/v1alpha1
kind: StaticRoute
metadata:
  creationTimestamp: "2022-12-14T09:32:15Z"
  finalizers:
  - gateway.kusk.io/srfinalizer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
2 participants